Bug 1598528

Summary: [RFE] Automate - Expose max_retries override at instance level
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Yadnyawalk Tale <ytale>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.0CC: bthurber, cpelland, hkataria, jprause, lavenel, mpovolny, obarenbo, smallamp
Target Milestone: GAKeywords: FutureFeature, ZStream
Target Release: 5.9.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.4.1 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1596338 Environment:
Last Closed: 2018-09-04 18:00:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core
Bug Depends On: 1596338    
Bug Blocks: 1564236    
Attachments:
Description Flags
automate.log none

Comment 2 CFME Bot 2018-07-11 15:31:44 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:

https://github.com/ManageIQ/manageiq-ui-classic/commit/b50a100152bfd246630121d0e0da12b499e22e89
commit b50a100152bfd246630121d0e0da12b499e22e89
Author:     Dan Clarizio <dclarizi@redhat.com>
AuthorDate: Wed Mar 14 17:42:22 2018 -0400
Commit:     Dan Clarizio <dclarizi@redhat.com>
CommitDate: Wed Mar 14 17:42:22 2018 -0400

    Merge pull request #3562 from h-kataria/add_max_retries_for_instances

    Added Max Retries text field on Instance screen
    (cherry picked from commit 81d2462db09f354460390d384af6f6948ef6545e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1598528

 app/controllers/miq_ae_class_controller.rb | 2 +-
 app/helpers/miq_ae_class_helper.rb | 4 +
 app/views/miq_ae_class/_instance_fields.html.haml | 34 +-
 app/views/miq_ae_class/_instance_form.html.haml | 66 +-
 4 files changed, 68 insertions(+), 38 deletions(-)

Comment 5 Yadnyawalk Tale 2018-08-01 14:04:49 UTC
Created attachment 1472097 [details]
automate.log

I can confirm max_retries at instance level in StateMachines UI.
Rechecked it by executing state machine via simulation.

1. Created domain and class
2. Created `meth1` method and `meth1_instance` instance in class
(domain attached)
3. Created state machine, added instance there and pointed value to `meth1_instance`
4. Added max_retries value as 3 in instance and 2 in class
5. In simulation, used `Call_Instance` with namespace, class and instance with Attribute/Value Pairs.

After submiting request we got three retries, which was what we were expected.
(automation.log attached)

Found features works very well, great work folks!
Verified on: 5.9.4.1.20180726225200_f44ec83

Thanks!

Comment 8 errata-xmlrpc 2018-09-04 18:00:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2561