Bug 1598663

Summary: Don't execute statements after decrementing call count in afr
Product: [Community] GlusterFS Reporter: Pranith Kumar K <pkarampu>
Component: replicateAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1599629 (view as bug list) Environment:
Last Closed: 2018-10-23 15:13:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1599629    

Description Pranith Kumar K 2018-07-06 07:01:56 UTC
Description of problem:
    When call_count is decremented by one thread, another thread can
    go ahead with the operation leading to undefined behavior for the
    thread executing statements after decrementing call count.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-07-06 08:39:53 UTC
REVIEW: https://review.gluster.org/20470 (cluster/afr: Prevent execution of code after call_count decrementing) posted (#1) for review on master by Pranith Kumar Karampuri

Comment 2 Worker Ant 2018-07-10 08:47:13 UTC
COMMIT: https://review.gluster.org/20470 committed in master by "Pranith Kumar Karampuri" <pkarampu> with a commit message- cluster/afr: Prevent execution of code after call_count decrementing

Problem:
When call_count is decremented by one thread, another thread can
go ahead with the operation leading to undefined behavior for the
thread executing statements after decrementing call count.

Fix:
Do the operations necessary before decrementing call count.

fixes bz#1598663
Change-Id: Icc90cd92ac16e5fbdfe534d9f0a61312943393fe
Signed-off-by: Pranith Kumar K <pkarampu>

Comment 3 Shyamsundar 2018-10-23 15:13:25 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/