Bug 1599139

Summary:	RFE: Support genid in virt-manager
Product:	Red Hat Enterprise Linux 8	Reporter:	Han Han <hhan>
Component:	virt-manager	Assignee:	Pavel Hrdina <phrdina>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.1	CC:	dyuan, juzhou, mxie, phrdina, tzheng, xiaodwan, xuzhang
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	8.1
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	virt-manager-2.2.0-1.el8	Doc Type:	Enhancement
Doc Text:	Feature: Add support for VM Generation ID Reason: Allows the guest the ability to detect when there is the possibility that the guest is potentially re-executing something that has already been executed before. Result: The VM Generatation ID exposes a 128-bit, cryptographically random, integer value identifier, referred to as a Globally Unique Identifier (GUID) to the guest in order to notify the guest operating system when the virtual machine is executed with a different configuration. Add a new CLI parameters to set specific genid or to let libvirt generate one.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-05 21:19:13 UTC	Type:	Feature Request
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1149445
Bug Blocks:

Description Han Han 2018-07-09 03:43:46 UTC

Description of problem:
As subject.

In virt-manager, please show genid in VM info page.
In virt-install, please add --metadata genid= option
In virt-clone, please generate new genid for VM cloned from VM with genid.

Comment 3 Pavel Hrdina 2019-01-16 09:01:35 UTC

Moving to RHEL-8 where we will implement only virt-install/virt-xml support.

Comment 4 Pavel Hrdina 2019-05-31 14:24:50 UTC

Upstream commit:

commit a6b5f11f1343fa1af96e083b3dafc9568e937497
Author: Cole Robinson <crobinso>
Date:   Tue May 14 14:26:19 2019 -0400

    cli: --metadata: add genid= and genid_enable=

Comment 7 zhoujunqin 2019-07-25 09:14:57 UTC

Try to verify this bug with new build:
gtksourceview3-3.24.9-1.el8.x86_64
virt-manager-2.2.1-1.el8.noarch
virt-install-2.2.1-1.el8.noarch
libvirt-4.5.0-24.module+el8.1.0+3205+41ff0a42.x86_64
qemu-kvm-2.12.0-77.module+el8.1.0+3382+49219945.x86_64

Steps:
1. Check sub options for "--metadata"

# virt-install --metadata=?
--metadata options:
  clearxml
  description
  genid
  genid_enable
  name
  os_full_id
  os_name
  title
  uuid

Result: 'genid=' and 'genid_enable=' are added.

2. Install a vm with genid set.
2.1 Using 'genid_enable=yes'
# virt-install --name testvm1  --memory 1024 --vcpus 1  --cdrom /root/Downloads/RHEL-8.0.0-20190404.2-x86_64-dvd1.iso  --nodisk --metadata genid_enable=yes
...
<domain type='kvm' id='3'>
  <name>testvm1</name>
  <uuid>116135cb-ae4f-4266-85e8-f0fde39ee9ef</uuid>
  <genid>831c2ab2-73d3-4587-b643-2927da4a8466</genid>
  <metadata>
    <libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0">
      <libosinfo:os id="http://redhat.com/rhel/8.0"/>
    </libosinfo:libosinfo>
  </metadata>

2.2 Using specified genid.
# virt-install --name testvm  --memory 1024 --vcpus 1  --cdrom /root/Downloads/RHEL-8.0.0-20190404.2-x86_64-dvd1.iso  --nodisk --metadata title=test-title,description=test-description,uuid=00000000-1111-2222-3333-444444444444,genid=e9392370-2917-565e-692b-d057f46512d6 
...
<domain type="kvm">
  <name>testvm</name>
  <uuid>00000000-1111-2222-3333-444444444444</uuid>
  <genid>e9392370-2917-565e-692b-d057f46512d6</genid>
  <title>test-title</title>
  <description>test-description</description>
  <metadata>
    <libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0">
      <libosinfo:os id="http://redhat.com/rhel/8.0"/>
    </libosinfo:libosinfo>
  </metadata>
...

Result: Installation finishes successfully with genid set.

So I move this bug from ON_QA to VERIFIED.

Comment 9 errata-xmlrpc 2019-11-05 21:19:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3464