Bug 1599629

Summary:	Don't execute statements after decrementing call count in afr
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.1	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-4.1.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1598663	Environment:
Last Closed:	2018-07-30 19:02:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1598663
Bug Blocks:

Description Pranith Kumar K 2018-07-10 08:48:24 UTC

+++ This bug was initially created as a clone of Bug #1598663 +++

Description of problem:
    When call_count is decremented by one thread, another thread can
    go ahead with the operation leading to undefined behavior for the
    thread executing statements after decrementing call count.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2018-07-06 04:39:53 EDT ---

REVIEW: https://review.gluster.org/20470 (cluster/afr: Prevent execution of code after call_count decrementing) posted (#1) for review on master by Pranith Kumar Karampuri

--- Additional comment from Worker Ant on 2018-07-10 04:47:13 EDT ---

COMMIT: https://review.gluster.org/20470 committed in master by "Pranith Kumar Karampuri" <pkarampu> with a commit message- cluster/afr: Prevent execution of code after call_count decrementing

Problem:
When call_count is decremented by one thread, another thread can
go ahead with the operation leading to undefined behavior for the
thread executing statements after decrementing call count.

Fix:
Do the operations necessary before decrementing call count.

fixes bz#1598663
Change-Id: Icc90cd92ac16e5fbdfe534d9f0a61312943393fe
Signed-off-by: Pranith Kumar K <pkarampu>

Comment 1 Worker Ant 2018-07-10 08:50:39 UTC

REVIEW: https://review.gluster.org/20486 (cluster/afr: Prevent execution of code after call_count decrementing) posted (#1) for review on release-4.1 by Pranith Kumar Karampuri

Comment 2 Worker Ant 2018-07-23 23:41:14 UTC

COMMIT: https://review.gluster.org/20486 committed in release-4.1 by "Pranith Kumar Karampuri" <pkarampu> with a commit message- cluster/afr: Prevent execution of code after call_count decrementing

Problem:
When call_count is decremented by one thread, another thread can
go ahead with the operation leading to undefined behavior for the
thread executing statements after decrementing call count.

Fix:
Do the operations necessary before decrementing call count.

fixes bz#1599629
Change-Id: Icc90cd92ac16e5fbdfe534d9f0a61312943393fe
Signed-off-by: Pranith Kumar K <pkarampu>
(cherry picked from commit 03f1f5bdc46076178f1afdf8e2a76c5b973fe11f)

Comment 3 Shyamsundar 2018-07-30 19:02:48 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.1.2, please open a new bug report.

glusterfs-4.1.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-July/000106.html
[2] https://www.gluster.org/pipermail/gluster-users/