Bug 1600330
Summary: | The dumped filterbinding can not pass the xml validate | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | yalzhang <yalzhang> |
Component: | libvirt | Assignee: | John Ferlan <jferlan> |
Status: | CLOSED ERRATA | QA Contact: | yalzhang <yalzhang> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 7.6 | CC: | chhu, fjin, lmen, xuzhang |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | libvirt-4.5.0-4.el7 | Doc Type: | No Doc Update |
Doc Text: |
undefined
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2018-10-30 09:58:24 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
yalzhang@redhat.com
2018-07-12 01:55:42 UTC
Patch posted upstream: https://www.redhat.com/archives/libvir-list/2018-July/msg00816.html Now pushed upstream: $ git show commit a47d053720f3b4965184bc9a5a87a86d301957ea Author: Han Han <hhan> Date: Fri Jul 13 09:39:29 2018 +0800 virt-xml-validate: Add schema for nwfilterbinding ... Add nwfilterbinding schema in virt-xml-validate for autoprobing. Add document of nwfilterbinding schema in tools/virt-xml-validate.pod. Signed-off-by: Han Han <hhan> Reviewed-by: John Ferlan <jferlan> $ git describe a47d053720f3b4965184bc9a5a87a86d301957ea v4.5.0-193-ga47d053720 $ test on libvirt-4.5.0-4.el7.x86_64, the result is as expected, set this bug to be verified. 1. collect all the built-in nwfilter name in a file called 'test' # virsh nwfilter-list > test # cat test allow-arp allow-dhcp allow-dhcp-server ... 2. prepare xmls included different filters # cat run.sh #!/bin/bash k=1 while read line; do echo "<interface type='network'> <source network='default'/> <filterref filter='$line'/> </interface> " > vnet$k ((k++)) done < test #./run.sh 3. Find the interface with 'allow-dhcp-server' filter, edit the file to add the dhcp server parameter # cat vnet3 <interface type='network'> <source network='default'/> <filterref filter='allow-dhcp-server'> <parameter name='DHCPSERVER' value='192.168.122.1'/> </filterref> </interface> 4. prepare configs with parameters: # cat vnet18 <interface type='bridge'> <source bridge='br0'/> <mac address='00:16:3e:5d:c7:9e'/> <filterref filter='clean-traffic'> <parameter name='IP' value='10.0.0.1'/> <parameter name='IP' value='10.0.0.2'/> <parameter name='IP' value='10.0.0.3'/> </filterref> </interface> # cat vnet19 <interface type='bridge'> <source bridge='br0'/> <filterref filter='clean-traffic'> <parameter name='CTRL_IP_LEARNING' value='dhcp'/> </filterref> </interface> # for i in {1..19}; do virsh attach-device rhel vnet$i --config; done # virsh start rhel # for i in {1..19}; do virsh nwfilter-binding-dumpxml vnet$i > binding$i; virt-xml-validate binding$i;done binding1 validates binding2 validates binding3 validates binding4 validates binding5 validates binding6 validates binding7 validates binding8 validates binding9 validates binding10 validates binding11 validates binding12 validates binding13 validates binding14 validates binding15 validates binding16 validates binding17 validates binding18 validates binding19 validates Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:3113 |