Bug 1600345

Summary: Can not edit alias name for vsock device
Product: Red Hat Enterprise Linux 7 Reporter: yafu <yafu>
Component: libvirtAssignee: Erik Skultety <eskultet>
Status: CLOSED ERRATA QA Contact: yafu <yafu>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.6CC: dyuan, fjin, hhan, jdenemar, lizhu, lmen, xuzhang, yanqzhan
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-4.5.0-3.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1600366 (view as bug list) Environment:
Last Closed: 2018-10-30 09:58:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1600366    

Description yafu 2018-07-12 03:51:42 UTC
Description of problem:
Can not edit alias name for vsock device

Version-Release number of selected component (if applicable):
libvirt-4.5.0-2.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Add a vsock device with alias name and save the xml:
#virsh edit iommu1
 <vsock model='virtio'>
      <cid auto='no' address='3'/>
      <alias name='ua-04c33ecd-4e33-4023-84de-a2205c777asdfdsf'/>
      <address type='pci' domain='0x0000' bus='0x09' slot='0x00' function='0x0'/>
    </vsock>
# virsh edit iommu1
error: XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/domain.rng
Extra element devices in interleave
Element domain failed to validate content

Failed. Try again? [y,n,i,f,?]: 


2.Check the rng file:
#cat /usr/share/libvirt/schemas/domaincommon.rng
no alias name for vsock device

3.

Actual results:
Can not edit alias name for vsock device

Expected results:
Can edit alias name fro vsock device

Additional info:

Comment 3 Han Han 2018-07-13 08:56:59 UTC
Patch accepted:
commit c03d36b91d62890b376a2ff8f9d65fac069dce42 (HEAD -> master)
Author: Han Han <hhan>
Date:   Thu Jul 12 14:28:17 2018 +0800

    docs: schema: Add missing <alias> to vsock device
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1600345
    
    Signed-off-by: Han Han <hhan>
    Reviewed-by: Erik Skultety <eskultet>


Change to post status.

Comment 6 yafu 2018-07-22 08:15:32 UTC
Verified with libvirt-4.5.0-3.el7.x86_64.

Comment 8 errata-xmlrpc 2018-10-30 09:58:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:3113