Bug 1600529

 - Make a Python 2 subpackage

 - Use %py2_build instead of %{__python2} setup.py build
 / %py2_install instead of %{__python2} setup.py install --skip-build --root %{buildroot}

 - Make a Py3 subpackage ? You can use: "pyp2rpm -b3 -p2 XStatic-Angular-UUID" to help you

Also Release should start at 1 not 0.

%py2_build doesn't seem to do anything

Thank you for the review, I applied all the comments you had. Adding the python 3 package was a little bit more involved, since there are common files shared between both python versions, but I resolved it by adding a -common package.

The URL for the new srpm is:
https://github.com/deshipu/python-XStatic-Angular-UUID/raw/master/python-XStatic-Angular-UUID-0.0.4.0-1.fc28.src.rpm

The spec file has the same URL.

You didn't make a python 2 subpackage, the main package should be python-XStatic-Angular-UUID, with two subpackage python2-XStatic-Angular-UUID and python3-XStatic-Angular-UUID. No Provides:       python2-%{pypi_name} = %{version}-%{release}.

See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

I did what all the other xstatic packages are doing, but I will try to fix it the way you want it.

Updated the spec file.

Looks good.

Got a build error:

Traitement des fichiers : python2-XStatic-Angular-UUID-0.0.4.0-1.fc29.noarch
BUILDSTDERR: error : File not found : /builddir/build/BUILDROOT/python-XStatic-Angular-UUID-0.0.4.0-1.fc29.x86_64/usr/lib/python2.7/site-packages/XStatic_Angular_UUID-0.0.4.0-py.egg-info
BUILDSTDERR: error : File not found : /builddir/build/BUILDROOT/python-XStatic-Angular-UUID-0.0.4.0-1.fc29.x86_64/usr/lib/python2.7/site-packages/XStatic_Angular_UUID-0.0.4.0-py-nspkg.pth
Exécution_de(%doc) : /bin/sh -e /var/tmp/rpm-tmp.OXbbMF

Use:

%{python2_sitelib}/XStatic_Angular_UUID-%{version}-py%{python2_version}.egg-info
%{python2_sitelib}/XStatic_Angular_UUID-%{version}-py%{python2_version}-nspkg.pth


%{python_version} was removed in F29. Alternatively just use ?.? instead of the exact version.


Package is approved, just fix the above error before import.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 15 files have unknown license. Detailed
     output of licensecheck in /home/bob/packaging/review/python-XStatic-
     Angular-UUID/review-python-XStatic-Angular-UUID/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.7/site-packages/xstatic/pkg,
     /usr/lib/python3.7/site-packages/xstatic
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.7/site-
     packages, /usr/lib/python3.7, /usr/lib/python3.7/site-
     packages/xstatic/pkg, /usr/lib/python3.7/site-packages/xstatic
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xstatic-
     angular-uuid-common , python2-XStatic-Angular-UUID , python3-XStatic-
     Angular-UUID
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: xstatic-angular-uuid-common-0.0.4.0-1.fc29.noarch.rpm
          python2-XStatic-Angular-UUID-0.0.4.0-1.fc29.noarch.rpm
          python3-XStatic-Angular-UUID-0.0.4.0-1.fc29.noarch.rpm
          python-XStatic-Angular-UUID-0.0.4.0-1.fc29.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-XStatic-Angular-UUID

Please don't use following construction.

%if 0%{?fedora}
%global with_python3 1
%endif

Use this instead:

%if 0%{?rhel} && 0%{?rhel} <= 7
%bcond_with python3
%else
%bcond_without python3
%endif.

Thank you Igor for the advice, do you have some package where that construct is used, so that I can see it in context? I'm not sure how to later check the conditions.

Do you have an example spec file where this is used? I'm not sure how to write the conditions with what you are proposing.

For example


https://src.fedoraproject.org/rpms/python-graphitesend/blob/master/f/python-graphitesend.spec


https://src.fedoraproject.org/rpms/python-jaydebeapi/blob/master/f/python-jaydebeapi.spec

Thank you, that's very helpful.