Bug 1601482
| Summary: | /usr/include/attr/xattr.h is absent from libattr-devel-2.4.48-1 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrice LUCAS <patrice.lucas> |
| Component: | attr | Assignee: | Kamil Dudka <kdudka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 28 | CC: | awilliam, g.fhnrunznrqeqf, kdudka, projects.rg, svashisht |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | attr-2.4.48-3.fc29 attr-2.4.48-3.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-22 03:03:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Patrice LUCAS
2018-07-16 13:17:48 UTC
This was apparently an intentional change: per Petr Pisar, "This is an intentional change. Applications should use sys/xattr.h instead provided by glibc." Elsewhere, Richard W.M. Jones provided these recommendations:
To provide for both locations we use this in configure.ac:
AC_CHECK_HEADERS([\
attr/xattr.h \
sys/xattr.h])
and this in each source file which needs the header:
#include <config.h>
#ifdef HAVE_ATTR_XATTR_H
# include <attr/xattr.h>
#else
# ifdef HAVE_SYS_XATTR_H
# include <sys/xattr.h>
# endif
#endif
Rich.
Yes, this is an intentional change upstream. I overlooked the change while updating the package because attr.spec lists /usr/include/attr and not the individual header files. I will hotfix it temporarily by providing a symlink /usr/include/attr/xattr.h -> ../sys/xattr.h which will be removed in the next release of Fedora via properly announced Fedora change. attr-2.4.48-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8c0b389f3 (In reply to Kamil Dudka from comment #2) > Yes, this is an intentional change upstream. I overlooked the change while > updating the package because attr.spec lists /usr/include/attr and not the > individual header files. > > I will hotfix it temporarily by providing a symlink > /usr/include/attr/xattr.h -> ../sys/xattr.h which will be removed in the > next release of Fedora via properly announced Fedora change. Thanks a lot ! Thank you for being highly responsive. You quickly fixed it and your solution perfectly fits our development process (The symlink fixs the current continuous integration tests and we are updating our product for the next version of Fedora.) No problem. Thank you for verifying the temporary fix! attr-2.4.48-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8c0b389f3 This issue affects koschei with ecryptfs-utils in F28. (In reply to Raphael Groner from comment #8) > This issue affects koschei with ecryptfs-utils in F28. ecryptfs-utils-111-12.fc29 now builds successfully against attr-2.4.48-3.fc29: https://apps.fedoraproject.org/koschei/build/5019858 ... and it will build successfully in f28, too, once this is pushed to stable. attr-2.4.48-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |