Bug 1601605

Summary:	openshift logging Ansible playbook installation while defining PVC manifest a match label selector should use value 'true' in quotes to avoid it to understandable as a Boolean value.
Product:	OpenShift Container Platform	Reporter:	Jeff Cantrill <jcantril>
Component:	Logging	Assignee:	Jeff Cantrill <jcantril>
Status:	CLOSED ERRATA	QA Contact:	Anping Li <anli>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.9.0	CC:	anli, aos-bugs, grajawat, mark.vinkx, qitang, rmeggins
Target Milestone:	---
Target Release:	3.9.z
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: Ansible template did not quote the value in the selector Consequence: Invalid JSON was produced Fix: Quote the selector value Result: Able to create a pvc with selector	Story Points:	---
Clone Of:	1597282	Environment:
Last Closed:	2018-08-29 14:42:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1597282, 1601606
Bug Blocks:

Description Jeff Cantrill 2018-07-16 20:40:46 UTC

+++ This bug was initially created as a clone of Bug #1597282 +++

Description of problem:

Open shift logging installation via Ansible playbook with parameter openshift_logging_es_pv_selector={"logging-es":"true"} failed


Version-Release number of selected component (if applicable): 3.7 


How reproducible:

Host file entry:

openshift_logging_es_pv_selector={"logging-es":"true"}


Steps to Reproduce:
1. Inject openshift_logging_es_pv_selector={"logging-es":"true"} in Host file
2. ansible-playbook -i host /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/openshift-logging.yml


Actual results:
Installation successful 


Expected results:

"stderr": "Error from server (BadRequest): error when creating \"/tmp/openshift-logging-ansible-JGyENQ/templates/logging-es-pvc.yml\": PersistentVolumeClaim in version \"v1\" cannot be handled as a PersistentVolumeClaim: [pos 276]: json: expect char '\"' but got char '1'\n",


Additional info:

- Ansible create PVC manifest a match label selector value true without quotes.
- The value 'true' should be in quotes to avoid it to understandable as a Boolean value.

--- Additional comment from markv on 2018-07-02 09:54:32 EDT ---

The same problem with numeric values

--- Additional comment from Jeff Cantrill on 2018-07-11 16:46:40 EDT ---

Please provide the version of ansible where you saw this failure.

Comment 2 Qiaoling Tang 2018-08-27 04:17:45 UTC

Verified on openshift-ansible-3.9.41-1.git.0.4c55974.el7.noarch

Comment 4 errata-xmlrpc 2018-08-29 14:42:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2549