Bug 1602072
Summary: | [RFE] List prices of catalogs before user orders on service catalog screen | ||
---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Tuan <tuado> |
Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> |
Status: | CLOSED ERRATA | QA Contact: | Niyaz Akhtar Ansari <nansari> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 5.8.0 | CC: | duhlmann, gekis, hkataria, jocarter, lavenel, mfeifer, mpovolny, obarenbo, simaishi, smallamp |
Target Milestone: | GA | Keywords: | FutureFeature, RFE |
Target Release: | 5.11.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | 5.11.0.13 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-12-12 13:34:23 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | Feature | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | CFME Core | Target Upstream Version: | |
Embargoed: |
Description
Tuan
2018-07-17 18:40:19 UTC
New commit detected on ManageIQ/manageiq-schema/master: https://github.com/ManageIQ/manageiq-schema/commit/1b13ad2e622138909bf8c3d7ed01f1aba25d461f commit 1b13ad2e622138909bf8c3d7ed01f1aba25d461f Author: Lucy Fu <lufu> AuthorDate: Mon May 13 14:40:31 2019 -0400 Commit: Lucy Fu <lufu> CommitDate: Mon May 13 14:40:31 2019 -0400 Add price to service templates. https://bugzilla.redhat.com/show_bug.cgi?id=1602072 db/migrate/20190513155251_add_price_to_service_templates.rb | 6 + 1 file changed, 6 insertions(+) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/43bc02dd1a32f21a870185f32c81934d699d1744 commit 43bc02dd1a32f21a870185f32c81934d699d1744 Author: Lucy Fu <lufu> AuthorDate: Mon May 13 14:39:57 2019 -0400 Commit: Lucy Fu <lufu> CommitDate: Mon May 13 14:39:57 2019 -0400 Add currency to service template. https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/models/service_template.rb | 1 + 1 file changed, 1 insertion(+) New commit detected on ManageIQ/manageiq-schema/master: https://github.com/ManageIQ/manageiq-schema/commit/789f01ce7c20efa48ac36f0c03678d64419ca50d commit 789f01ce7c20efa48ac36f0c03678d64419ca50d Author: Lucy Fu <lufu> AuthorDate: Mon May 20 13:50:16 2019 -0400 Commit: Lucy Fu <lufu> CommitDate: Mon May 20 13:50:16 2019 -0400 Add columns of price and currency to services. https://bugzilla.redhat.com/show_bug.cgi?id=1602072 db/migrate/20190520174739_add_price_to_services.rb | 6 + 1 file changed, 6 insertions(+) New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/9ad9add510196d765a053fc99327ea489bb8886c commit 9ad9add510196d765a053fc99327ea489bb8886c Author: Harpreet Kataria <hkataria> AuthorDate: Mon Jun 17 17:13:29 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Jun 17 17:13:29 2019 -0400 Added Price to Catalog Items. Added Currency drop down and Price text field to Angular and non-angular Catalog Item editors. And update Catalog Item details screen t show the price information. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/assets/javascripts/controllers/catalog/catalog_item_form_controller.js | 11 +- app/assets/javascripts/controllers/playbook-reusable-code-mixin.js | 10 + app/controllers/catalog_controller.rb | 18 + app/views/catalog/_form_basic_info.html.haml | 27 + app/views/catalog/_sandt_tree_show.html.haml | 5 + app/views/catalog/_st_angular_form.html.haml | 21 + app/views/catalog/_svccat_tree_show.html.haml | 7 +- spec/javascripts/controllers/catalog/catalog_item_form_controller_spec.js | 2 + 8 files changed, 98 insertions(+), 3 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/1bc6b5572f0db9927752ee6b1fb3d48b3bc1ed13 commit 1bc6b5572f0db9927752ee6b1fb3d48b3bc1ed13 Author: Harpreet Kataria <hkataria> AuthorDate: Mon Jun 24 13:40:41 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Jun 24 13:40:41 2019 -0400 Addressed PR feedback Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/assets/javascripts/controllers/catalog/catalog_item_form_controller.js | 2 +- app/controllers/catalog_controller.rb | 4 +- app/views/catalog/_form_basic_info.html.haml | 4 +- 3 files changed, 5 insertions(+), 5 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/7fe11f435361f662a66616030fa2bd828eefc98c commit 7fe11f435361f662a66616030fa2bd828eefc98c Author: Harpreet Kataria <hkataria> AuthorDate: Wed Jun 26 11:13:35 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jun 26 11:13:35 2019 -0400 Changed label `Rate` to `Price` Only show Price info on details screen when currency and price was set. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/controllers/catalog_controller.rb | 4 +- app/views/catalog/_form_basic_info.html.haml | 2 +- app/views/catalog/_sandt_tree_show.html.haml | 11 +- app/views/catalog/_st_angular_form.html.haml | 2 +- app/views/catalog/_svccat_tree_show.html.haml | 13 +- 5 files changed, 17 insertions(+), 15 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/64ac3cb3e3da7b113c81d4d2bda8faa01f26cd1f commit 64ac3cb3e3da7b113c81d4d2bda8faa01f26cd1f Author: Harpreet Kataria <hkataria> AuthorDate: Wed Jun 26 12:22:20 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jun 26 12:22:20 2019 -0400 Added missing changes to save price for catalog bundle Also made changes to show `Price` as required field if user has made selection in a currency drop down. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/assets/javascripts/controllers/catalog/catalog_item_form_controller.js | 10 +- app/controllers/catalog_controller.rb | 11 +- app/views/catalog/_st_angular_form.html.haml | 7 +- 3 files changed, 25 insertions(+), 3 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/fcb613c2a0cdcdf24623df3b397fff983218e80e commit fcb613c2a0cdcdf24623df3b397fff983218e80e Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jun 27 10:44:23 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Jun 27 10:44:23 2019 -0400 Changed labels to `Price / Month` Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/controllers/catalog_controller.rb | 4 +- app/views/catalog/_sandt_tree_show.html.haml | 2 +- app/views/catalog/_st_angular_form.html.haml | 2 +- app/views/catalog/_svccat_tree_show.html.haml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/11a9375297714d568b31756ea12b6d782ab53f74 commit 11a9375297714d568b31756ea12b6d782ab53f74 Author: Harpreet Kataria <hkataria> AuthorDate: Mon Jul 1 19:33:02 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Jul 1 19:33:02 2019 -0400 Added validation on "Price" field Fixed to show label on Price field appropriately when adding new record, and fixed saving of new record when currency/price are both not entered by user. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/controllers/catalog_controller.rb | 12 +- app/views/catalog/_st_angular_form.html.haml | 3 + spec/controllers/catalog_controller_spec.rb | 51 + 3 files changed, 63 insertions(+), 3 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/acbccef0ee5a1652d090c284186d81fd739cec81 commit acbccef0ee5a1652d090c284186d81fd739cec81 Author: Harpreet Kataria <hkataria> AuthorDate: Wed Jul 3 10:12:32 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jul 3 10:12:32 2019 -0400 Some more fixes to price validation Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/assets/javascripts/controllers/catalog/catalog_item_form_controller.js | 4 +- app/controllers/catalog_controller.rb | 2 +- spec/controllers/catalog_controller_spec.rb | 8 + 3 files changed, 12 insertions(+), 2 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/3703088fbfb6a117f98b131daf36c3f7c6d07516 commit 3703088fbfb6a117f98b131daf36c3f7c6d07516 Author: Harpreet Kataria <hkataria> AuthorDate: Wed Jul 3 11:09:03 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jul 3 11:09:03 2019 -0400 Addressed rubocop warnings Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/controllers/catalog_controller.rb | 7 +- 1 file changed, 3 insertions(+), 4 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/12a460a9f08c071689cd837e9d83680974f05571 commit 12a460a9f08c071689cd837e9d83680974f05571 Author: Harpreet Kataria <hkataria> AuthorDate: Wed Jul 3 11:56:41 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jul 3 11:56:41 2019 -0400 Empty out Price value during save is currency was unset. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602072 app/assets/javascripts/controllers/catalog/catalog_item_form_controller.js | 7 +- app/controllers/catalog_controller.rb | 10 +- 2 files changed, 11 insertions(+), 6 deletions(-) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199 |