Bug 1602188

Summary: [Infra] New Transaction leak in org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager
Product: Red Hat OpenStack Reporter: Sai Sindhur Malleni <smalleni>
Component: opendaylightAssignee: Stephen Kitt <skitt>
Status: CLOSED ERRATA QA Contact: Sai Sindhur Malleni <smalleni>
Severity: medium Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: aadam, joflynn, jschluet, mkolesni, nyechiel, skitt
Target Milestone: z2Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: Infra
Fixed In Version: opendaylight-8.3.0-2.el7ost Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
N/A
Last Closed: 2018-08-29 16:20:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1577975    

Description Sai Sindhur Malleni 2018-07-18 01:19:32 UTC
Description of problem:
Running performance and scale tests that create 100s of neutron resources like networks, subnets, ports and routers and waiting for the environment to quiesce, we observe some new transaction leaks based on Michael Vorburger's mdsal-trace tool.

    1283x transactions opened here, which are not closed:
      (...)
      org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)
      (...)
      org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.lambda$update$12(VpnInterfaceManager.java:1524)
      org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:416)
      org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60)
      java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402)
      java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
      java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
      java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
      java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

Version-Release number of selected component (if applicable):
OSP13
Puddle: 2018-07-13.1

How reproducible:
100%

Steps to Reproduce:
1. Run Browbeat+Rally neutron test suite
2. Get open transactions
3.

Actual results:
We see several open transactions after the tests finished running.

Expected results:

No open transactions
Additional info:

Comment 3 Ariel Adam 2018-07-23 05:46:46 UTC
Patch has been merged upstream.

Comment 4 Sai Sindhur Malleni 2018-07-24 15:35:38 UTC
Another trace from same setup, 

 1283x transactions opened here, which are not closed:
      (...)
      org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)
      (...)
      org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.lambda$update$12(VpnInterfaceManager.java:1523)
      org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:416)
      org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60)
      java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402)
      java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
      java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
      java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
      java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

Comment 5 Stephen Kitt 2018-07-24 16:34:39 UTC
(In reply to Sai Sindhur Malleni from comment #4)
> Another trace from same setup, 
> 
>  1283x transactions opened here, which are not closed:
>       (...)
>      
> org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.
> newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69)
>       (...)
>      
> org.opendaylight.netvirt.vpnmanager.VpnInterfaceManager.
> lambda$update$12(VpnInterfaceManager.java:1523)

This is also dealt with by the patch referenced in the links.

Comment 12 Joanne O'Flynn 2018-08-14 09:45:49 UTC
This bug is marked for inclusion in the errata but does not currently contain draft documentation text. To ensure the timely release of this advisory please provide draft documentation text for this bug as soon as possible.

If you do not think this bug requires errata documentation, set the requires_doc_text flag to "-".


To add draft documentation text:

* Select the documentation type from the "Doc Type" drop down field.

* A template will be provided in the "Doc Text" field based on the "Doc Type" value selected. Enter draft text in the "Doc Text" field.

Comment 13 Sai Sindhur Malleni 2018-08-16 11:57:17 UTC
Verified this on opendaylight-8.3.0-3.el7ost.noarch

Comment 15 errata-xmlrpc 2018-08-29 16:20:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2598