Bug 1602367

Summary: Hammer/API - wrong error message
Product: Red Hat Satellite Reporter: Martin Korbel <mkorbel>
Component: AuthenticationAssignee: Marek Hulan <mhulan>
Status: CLOSED ERRATA QA Contact: Jameer Pathan <jpathan>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.4CC: jpathan, lzap, mhulan, pcreech, tbrisker
Target Milestone: 6.5.0Keywords: Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-14 12:37:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Korbel 2018-07-18 09:22:32 UTC
Description of problem:
When we do brute force password attack via hammer (min. 30 trying), it returns the message "Invalid username or password." 
After that we put a correct credential, but hammer/API still return the same message "Invalid username or password.". It is little confusing. 

Version-Release number of selected component (if applicable):
Sat6.4#11

How reproducible:
100%

Steps to Reproduce:
1. We have got Sat6.4 and client machine.
2. We register the client machine to Satellite 6.4 repo and install hammer (standalone)
  > yum install -y tfm-rubygem-hammer_cli_katello
  > hammer --fetch-ca-cert https://satellite.example.com/
  > install /root/.hammer/certs/satellite.example.com_443.pem /etc/pki/ca-trust/source/anchors/
  > update-ca-trust

3. Check hammer
> hammer -u admin -p correct_password user list
...

4. Brute force password attack
> for i in {1..30}; do hammer -u admin -p bad_password user list; done
Invalid username or password.
Invalid username or password.
...
Invalid username or password.
Invalid username or password.

5. Check hammer with the correct password
> hammer -u admin -p correct_password user list

Actual results:
we get the message "Invalid username or password."

Expected results:
We should get the message "Too many tries, please try again in a few minutes.". The same as via WebUI.


Additional info:
> hammer -d -u admin -p correct_password user list
...
[DEBUG 2018-07-18T04:58:00 API] Using authenticator: HammerCLIForeman::Api::InteractiveBasicAuth
[ERROR 2018-07-18T04:58:00 API] 401 Unauthorized
[DEBUG 2018-07-18T04:58:00 API] {
    "error" => {
        "message" => "Unable to authenticate user "
    }
}
[DEBUG 2018-07-18T04:58:00 Exception] Using exception handler HammerCLIForeman::ExceptionHandler#handle_foreman_unauthorized
[ERROR 2018-07-18T04:58:00 Exception] Invalid username or password.
Invalid username or password.
[ERROR 2018-07-18T04:58:00 Exception] 

HammerCLIForeman::Api::UnauthorizedError (Invalid username or password.):
...

Comment 1 Marek Hulan 2018-07-18 11:48:47 UTC
Created redmine issue https://projects.theforeman.org/issues/24284 from this bug

Comment 5 Jameer Pathan 2018-11-15 10:14:50 UTC
verified:

@satellite 6.5.0 snap 3

steps:
# for i in {1..30}; do hammer -u admin -p bad_password user list; done
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
Unable to authenticate user admin
[root@dell-pe-fm120-2d ~]# hammer -u admin -p correct_password user list
Too many tries, please try again in a few minutes.


observation:
-"Too many tries, please try again in a few minutes." through hammer. The same as via WebUI.

Comment 9 errata-xmlrpc 2019-05-14 12:37:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:1222