Bug 1603421

Summary: aspell-sk: FTBFS in Fedora rawhide
Product: [Fedora] Fedora Reporter: Mohan Boddu <mboddu>
Component: aspellAssignee: Nikola Forró <nforro>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: jchaloup, nforro, ondrejj
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: armv7hl   
OS: Linux   
Whiteboard:
Fixed In Version: aspell-0.60.6.1-25.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-18 02:03:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1602938    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Mohan Boddu 2018-07-19 14:48:21 UTC
aspell-sk failed to build from source in Fedora rawhide

https://koji.fedoraproject.org/koji/taskinfo?taskID=28167425


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
Please fix aspell-sk at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
aspell-sk will be orphaned. Before branching of Fedora 30,
aspell-sk will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Mohan Boddu 2018-07-19 14:48:26 UTC
Created attachment 1460529 [details]
build.log

file build.log too big, will only attach last 1024 bytes

Comment 2 Mohan Boddu 2018-07-19 14:48:29 UTC
Created attachment 1460530 [details]
root.log

file root.log too big, will only attach last 1024 bytes

Comment 3 Mohan Boddu 2018-07-19 14:48:31 UTC
Created attachment 1460531 [details]
state.log

Comment 4 Jan ONDREJ 2018-07-20 04:47:00 UTC
This looks like a problem of aspell, not just it's slovak dictionaty.

/usr/bin/prezip-bin -d < sk.cwl | /usr/bin/aspell  --lang=sk create master ./sk.rws
/bin/sh: line 1: 20060 Broken pipe             /usr/bin/prezip-bin -d < sk.cwl
     20061 Segmentation fault      (core dumped) | /usr/bin/aspell --lang=sk create master ./sk.rws
make: *** [Makefile:74: sk.rws] Error 139

Comment 5 Jan ONDREJ 2018-07-20 05:20:48 UTC
*** Bug 1605055 has been marked as a duplicate of this bug. ***

Comment 6 Jan Kurik 2018-08-14 09:49:43 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 7 Zbigniew Jędrzejewski-Szmek 2018-08-27 09:24:32 UTC
There has been at least one successfull build after mass rebuild.

aspell-0.60.6.1-24.fc29: https://koji.fedoraproject.org/koji/buildinfo?buildID=1106302

Comment 8 Jan ONDREJ 2018-08-27 10:09:31 UTC
Hmm, may be aspell main package builds successfully,  but doen't run successfully. Try to look at this build:

https://kojipkgs.fedoraproject.org//work/tasks/582/29330582/build.log
https://koji.fedoraproject.org/koji/taskinfo?taskID=29330572

/usr/bin/prezip-bin -d < sk.cwl | /usr/bin/aspell  --lang=sk create master ./sk.rws
/bin/sh: line 1:  7666 Broken pipe             /usr/bin/prezip-bin -d < sk.cwl
      7667 Segmentation fault      (core dumped) | /usr/bin/aspell --lang=sk create master ./sk.rws

Looks like prezip-bin fails to run on armv7hl architecture.
Without a running prezip-bin I can't build aspell-sk subpackage.

Comment 9 Nikola Forró 2018-08-28 09:46:07 UTC
Yes, prezip-bin crashes on armv7hl, but only with "es", "pt_PT" and "sk" dictionaries, and only on Koji builders, I haven't been able to reproduce it anywhere else.

Comment 10 Jan ONDREJ 2018-08-28 10:49:35 UTC
Trying to update aspell-sk to upstream, but still fails to build, same problem.
https://koji.fedoraproject.org/koji/taskinfo?taskID=29345861

I can't build this package without a fully working aspell. :-(

Same problem for f28 and f29:
http://koji.fedoraproject.org/koji/buildinfo?buildID=1140024
http://koji.fedoraproject.org/koji/buildinfo?buildID=1140025

Do you have some armv7hl machines, where you can try this? I haven't.

If this is a problem of koji or fedora buildsystem, can you report it to fedora admins?

Thank you.

Comment 11 Nikola Forró 2018-08-28 11:00:11 UTC
> Do you have some armv7hl machines, where you can try this? I haven't.

Yes, I tried to reproduce the crash (unsuccessfully) on an armv7 test machine:
https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers

> If this is a problem of koji or fedora buildsystem, can you report it to fedora admins?

I don't think it is. I'll try to get some debugging information (backtrace) from a Koji builder by modifying the spec file.

Comment 12 Nikola Forró 2018-08-28 16:34:24 UTC
I've managed to track the problem down to this:
https://github.com/GNUAspell/aspell/blob/b2e2b25fe03f594f7db6a3451a11b7fea34f8103/modules/speller/default/language.cpp#L291

It seems the ".dat" string literal is wrongfully optimized out, and that leads to the crash. Turning off optimization helps. So I think it might be a bug in gcc.

Comment 13 Jan ONDREJ 2019-02-01 06:15:04 UTC
Any progress here?

Should this be assigned to gcc?

Fails to build in F30 too:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=32366625

Comment 14 Nikola Forró 2019-02-04 16:44:42 UTC
Sorry, not too much progress. It most likely is an optimization bug, but I haven't been able to come up with a self-contained reproducer.
However, according to my testing, it seems to be fixed in gcc9, so I think in Fedora 29 I'll just work it around by compiling that particular source file with -O1 instead of -O2.

Comment 15 Jan ONDREJ 2019-02-04 17:08:12 UTC
This latest report is against Fedora 30, which already has gcc9 and looks like aspell was compiled with this version, but still problems continue.

So I don't think, that gcc9 fixes this.

Optimization flags looks to be at least a partial solution until other fixes. Please do it to allow me to recompile aspell-sk. Thank you.

Comment 16 Nikola Forró 2019-02-05 13:14:36 UTC
As far as I can see, the latest build of aspell-sk in Koji (aspell-sk-2.02-2.fc30) was built with aspell-0.60.6.1-24.fc29, which was compiled with gcc8.

Comment 18 Fedora Update System 2019-02-05 13:37:30 UTC
aspell-0.60.6.1-25.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4aefd63307

Comment 19 Fedora Update System 2019-02-06 04:35:14 UTC
aspell-0.60.6.1-25.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4aefd63307

Comment 20 Fedora Update System 2019-02-06 15:00:12 UTC
aspell-0.60.6.1-25.fc29 aspell-es-1.11-16.fc29 aspell-pt_PT-20070510-15.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4aefd63307

Comment 21 Nikola Forró 2019-02-06 15:14:43 UTC
Jan,

I've created a build override for aspell-0.60.6.1-25.fc29, so you can rebuild aspell-sk and I'll add it to the update.

Comment 22 Jan ONDREJ 2019-02-07 11:23:05 UTC
Perfect. Thank you very much for help.

Currently F29 and F30 packages are built.

https://koji.fedoraproject.org/koji/buildinfo?buildID=1184393
https://koji.fedoraproject.org/koji/buildinfo?buildID=1140024

Comment 23 Fedora Update System 2019-02-07 11:28:39 UTC
aspell-sk-2.02-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-de1abe4d1d

Comment 24 Fedora Update System 2019-02-10 04:27:10 UTC
aspell-0.60.6.1-25.fc29, aspell-es-1.11-16.fc29, aspell-pt_PT-20070510-15.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4aefd63307

Comment 25 Fedora Update System 2019-02-10 04:27:39 UTC
aspell-sk-2.02-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-de1abe4d1d

Comment 26 Fedora Update System 2019-02-18 02:03:54 UTC
aspell-sk-2.02-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 27 Fedora Update System 2019-02-19 06:48:02 UTC
aspell-0.60.6.1-25.fc29, aspell-es-1.11-16.fc29, aspell-pt_PT-20070510-15.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 28 Fedora Update System 2019-02-19 14:01:10 UTC
aspell-0.60.6.1-25.fc29, aspell-es-1.11-16.fc29, aspell-pt_PT-20070510-15.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.