Bug 1605120

Summary: Update all packages action on host shows __init__() takes at least 2 arguments (1 given)
Product: Red Hat Satellite Reporter: Nikhil Kathole <nkathole>
Component: katello-agentAssignee: Justin Sherrill <jsherril>
Status: CLOSED ERRATA QA Contact: Nikhil Kathole <nkathole>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.4CC: cwelton, ehelms, jsherril, zhunting
Target Milestone: 6.4.0Keywords: Regression, Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: katello-host-tools-3.3.4-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-16 17:17:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot of UI
none
screenshot of UI update all packages none

Description Nikhil Kathole 2018-07-20 08:41:52 UTC
Created attachment 1464879 [details]
screenshot of UI

Description of problem: While trying to update all packages on host, task failed showing warning __init__() takes at least 2 arguments (1 given).


Version-Release number of selected component (if applicable):
Satellite 6.4 snap 12

How reproducible: always


Steps to Reproduce:
1. Navigate to Hosts- > content  and select any host
2. Click on tab "packages" -> actions
3. Click on Update All Packages

also reproducible using hammer

# hammer -v -u admin -p changeme host package upgrade-all --host-id="2"
[.........................................................................................................................................] [100%]
__init__() takes at least 2 arguments (1 given)
Error: __init__() takes at least 2 arguments (1 given)


Actual results: Task stopped showing warning

__init__() takes at least 2 arguments (1 given)

and production.log showed

2018-07-20T04:41:10 [E|bac|] __init__() takes at least 2 arguments (1 given) (Katello::Errors::PulpError)
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/lib/actions/pulp/consumer/abstract_content_action.rb:12:in `external_task='
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/action/polling.rb:98:in `poll_external_task_with_rescue'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/action/polling.rb:21:in `run'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/action/cancellable.rb:13:in `run'
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/lib/actions/pulp/abstract_async_task.rb:45:in `run'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/action.rb:538:in `block (3 levels) in execute_run'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware/stack.rb:26:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware.rb:18:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware.rb:31:in `run'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware/stack.rb:22:in `call'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware/stack.rb:26:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware.rb:18:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/lib/actions/middleware/remote_action.rb:16:in `block in run'
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/lib/actions/middleware/remote_action.rb:40:in `block in as_remote_user'
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/models/katello/concerns/user_extensions.rb:21:in `cp_config'
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/lib/actions/middleware/remote_action.rb:27:in `as_cp_user'
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/lib/actions/middleware/remote_action.rb:39:in `as_remote_user'
/opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.rc1.4/app/lib/actions/middleware/remote_action.rb:16:in `run'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware/stack.rb:22:in `call'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware/stack.rb:26:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware.rb:18:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman-tasks-0.13.2/app/lib/actions/middleware/rails_executor_wrap.rb:14:in `block in run'
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/execution_wrapper.rb:85:in `wrap'
/opt/theforeman/tfm/root/usr/share/gems/gems/foreman-tasks-0.13.2/app/lib/actions/middleware/rails_executor_wrap.rb:13:in `run'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware/stack.rb:22:in `call'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware/stack.rb:26:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/middleware.rb:18:in `pass'
/opt/theforeman/tfm/root/usr/share/gems/gems/dynflow-1.0.5/lib/dynflow/action/progress.rb:30:in `with_progress_calculation'



Expected results: Update all packages should successful. 


Additional info: Regression

Comment 4 Brad Buckingham 2018-07-20 19:48:40 UTC
Putting this on katello-agent, as the code has moved in to katello-host-tools.

Comment 5 Justin Sherrill 2018-07-20 21:19:50 UTC
client traceback:

 TypeError: __init__() takes at least 2 arguments (1 given)
     patterns = [Pattern(**u) for u in units]
   File "/usr/lib/python2.7/site-packages/katello/agent/pulp/handler.py", line 150, in update
     _report = handler.update(units, dict(options))
   File "/usr/lib/python2.7/site-packages/katello/agent/pulp/dispatcher.py", line 108, in update
 Traceback (most recent call last):
 Handler failed.

Comment 6 Justin Sherrill 2018-07-23 13:42:18 UTC
Created redmine issue https://projects.theforeman.org/issues/24353 from this bug

Comment 7 Satellite Program 2018-07-24 18:13:05 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/24353 has been resolved.

Comment 8 Nikhil Kathole 2018-07-30 12:13:48 UTC
VERIFIED

Version tested:
Satellite 6.4 snap 14

Update all packages on host works fine.

Comment 9 Nikhil Kathole 2018-07-30 12:14:25 UTC
Created attachment 1471523 [details]
screenshot of UI update all packages

Comment 11 errata-xmlrpc 2018-10-16 17:17:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2929