Bug 1605247

Summary: Check NSS crypto-polices
Product: [Fedora] Fedora Reporter: Kai Engert (:kaie) (inactive account) <kengert>
Component: crypto-policiesAssignee: Kai Engert (:kaie) (inactive account) <kengert>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: crypto-team, kengert, nmavrogi, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: crypto-policies-20180723-1.gitdb825c0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-30 08:49:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1428746    
Bug Blocks:    
Attachments:
Description Flags
patch v1 none

Description Kai Engert (:kaie) (inactive account) 2018-07-20 14:31:44 UTC
This is related to bug 1428746.
It suggest to enhance the crypto-policies package to perform the NSS checks, which are possible after bug 1428746 is done.

Comment 1 Kai Engert (:kaie) (inactive account) 2018-07-20 14:33:40 UTC
Created attachment 1464975 [details]
patch v1

I suggest this patch on top of the current git snapshot used by rawhide.
I'll attempt to submit a pull request for gitlab.

Comment 2 Kai Engert (:kaie) (inactive account) 2018-07-20 14:34:20 UTC
The .spec file needs to be extended with:

BuildRequires: perl(File::Which)
BuildRequires: nss-util

Comment 3 Kai Engert (:kaie) (inactive account) 2018-07-20 14:36:19 UTC
Comment on attachment 1464975 [details]
patch v1

I wasn't able to clone from gitlab using ssh. This would probably be required to be able to submit a pull request?

Comment 4 Kai Engert (:kaie) (inactive account) 2018-07-20 14:40:27 UTC
To test this enhancement, you can use the rawhide packages that contain a backport of the nss-policy-check utility:

https://koji.fedoraproject.org/koji/buildinfo?buildID=1129019
https://koji.fedoraproject.org/koji/buildinfo?buildID=1129065

Comment 5 Tomas Mraz 2018-07-23 12:21:49 UTC
(In reply to Kai Engert (:kaie) from comment #3)
> Comment on attachment 1464975 [details]
> patch v1
> 
> I wasn't able to clone from gitlab using ssh. This would probably be
> required to be able to submit a pull request?

Did you create an account and added your public ssh key to it?

Comment 6 Kai Engert (:kaie) (inactive account) 2018-07-23 12:33:08 UTC
yes, my account is kaie

Comment 7 Tomas Mraz 2018-07-23 12:48:00 UTC
To create the pull request you first fork the crypto-policies project to your account and then you work with your fork. When you commit what you want to merge, you create the pull request from your fork to the original repo.

Comment 8 Kai Engert (:kaie) (inactive account) 2018-07-23 13:58:33 UTC
Thanks for the reminder to fork. I've submitted the merge request.