Bug 1605956

Summary:	python-toro: FTBFS in Fedora rawhide
Product:	[Fedora] Fedora	Reporter:	Mohan Boddu <mboddu>
Component:	python-toro	Assignee:	Igor Raits <igor.raits>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	igor.raits, mhroncok
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-30 05:15:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1565020, 1602938

Description Mohan Boddu 2018-07-20 17:46:05 UTC

python-toro failed to build from source in Fedora rawhide

https://koji.fedoraproject.org/koji/taskinfo?taskID=28225639


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
Please fix python-toro at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
python-toro will be orphaned. Before branching of Fedora 30,
python-toro will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Miro Hrončok 2018-07-25 09:26:57 UTC

(This is a mass bug update. Forgive me if things are not 100% accurate for this one.)

At this moment, your package still requires Python 3.6. This will cause broken upgrades to Fedora 29. Please prioritize this rebuild.

Let me know if you need help from the Python maintenance team figuring out why the package FTBFS.

Consider orphaning the package if you don't have time for it.

Consider retiring the package if upstream is dead and nothing depends on it in Fedora.

If you are blocked by other packages (I've recently tried to set the Bugzilla metadata to reflect that), consider helping there as well. Thank you.

Comment 2 Igor Raits 2018-07-29 15:50:27 UTC

If you could help to find out why tests hang, would be helpful.

I would love to retire it, but thriftpy depends on it.

Comment 3 Miro Hrončok 2018-07-29 19:04:21 UTC

I'll investigate.


Hanging tests:

test_io_loop (test.test_queue.TestQueue3)
test_io_loop (test.test_queue.TestJoinableQueue3)


Failing tests:

======================================================================
FAIL: test_notify_1 (test.test_condition.TestCondition)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/build/lib/test/test_condition.py", line 39, in test_notify_1
    self.assertEqual(['wait1', 'notify1', 'wait2', 'notify2'], history)
AssertionError: Lists differ: ['wait1', 'notify1', 'wait2', 'notify2'] != ['notify1', 'notify2']

First differing element 0:
'wait1'
'notify1'

First list contains 2 additional elements.
First extra element 2:
'wait2'

- ['wait1', 'notify1', 'wait2', 'notify2']
+ ['notify1', 'notify2']

======================================================================
FAIL: test_notify_all (test.test_condition.TestCondition)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/build/lib/test/test_condition.py", line 68, in test_notify_all
    history)
AssertionError: Lists differ: [0, 1, 2, 3, 'notify_all'] != ['notify_all']

First differing element 0:
0
'notify_all'

First list contains 4 additional elements.
First extra element 1:
1

- [0, 1, 2, 3, 'notify_all']
+ ['notify_all']

======================================================================
FAIL: test_notify_all_with_timeout (test.test_condition.TestCondition)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 1147, in run
    yielded = self.gen.send(value)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 208, in send
    return self.__wrapped.send(val)
  File ".../toro/build/lib/test/test_condition.py", line 136, in test_notify_all_with_timeout
    self.assertEqual(['Timeout', 0, 2], history)
AssertionError: Lists differ: ['Timeout', 0, 2] != ['Timeout']

First list contains 2 additional elements.
First extra element 1:
0

- ['Timeout', 0, 2]
?           ------

+ ['Timeout']

======================================================================
FAIL: test_notify_n (test.test_condition.TestCondition)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/build/lib/test/test_condition.py", line 50, in test_notify_n
    self.assertEqual(list(range(3)), history)
AssertionError: Lists differ: [0, 1, 2] != []

First list contains 3 additional elements.
First extra element 0:
0

- [0, 1, 2]
+ []

======================================================================
FAIL: test_notify_n_with_timeout (test.test_condition.TestCondition)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 1147, in run
    yielded = self.gen.send(value)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 208, in send
    return self.__wrapped.send(val)
  File ".../toro/build/lib/test/test_condition.py", line 115, in test_notify_n_with_timeout
    self.assertEqual(['Timeout', 0, 2], history)
AssertionError: Lists differ: ['Timeout', 0, 2] != ['Timeout']

First list contains 2 additional elements.
First extra element 1:
0

- ['Timeout', 0, 2]
?           ------

+ ['Timeout']

======================================================================
FAIL: test_get_callback (test.test_async_result.TestAsyncResult)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/build/lib/test/test_async_result.py", line 72, in test_get_callback
    self.assertEqual(['get1', 'get2', 'set'], history)
AssertionError: Lists differ: ['get1', 'get2', 'set'] != ['set']

First differing element 0:
'get1'
'set'

First list contains 2 additional elements.
First extra element 1:
'get2'

- ['get1', 'get2', 'set']
+ ['set']

======================================================================
FAIL: test_queue_join_callback (test.test_queue.TestJoinableQueue3)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 307, in wrapper
    result = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 277, in wrapped
    coro = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 533, in pre_coroutine
    result = f(self, *args, **kwargs)
  File ".../toro/build/lib/test/test_queue.py", line 437, in test_queue_join_callback
    self.assertEqual(['task_done1', 'join', 'task_done2'], history)
AssertionError: Lists differ: ['task_done1', 'join', 'task_done2'] != ['task_done1', 'task_done2']

First differing element 1:
'join'
'task_done2'

First list contains 1 additional elements.
First extra element 2:
'task_done2'

- ['task_done1', 'join', 'task_done2']
?                --------

+ ['task_done1', 'task_done2']

======================================================================
FAIL: test_acquire_callback (test.test_lock.LockTests2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 307, in wrapper
    result = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 277, in wrapped
    coro = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 533, in pre_coroutine
    result = f(self, *args, **kwargs)
  File ".../toro/build/lib/test/test_lock.py", line 100, in test_acquire_callback
    self.assertEqual(['acquire1', 'acquire2', 'release'], history)
AssertionError: Lists differ: ['acquire1', 'acquire2', 'release'] != ['release']

First differing element 0:
'acquire1'
'release'

First list contains 2 additional elements.
First extra element 1:
'acquire2'

- ['acquire1', 'acquire2', 'release']
+ ['release']

======================================================================
FAIL: test_acquire_contended (test.test_rwlock.RWLockReadTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 326, in wrapper
    yielded = next(result)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 230, in __next__
    return next(self.__wrapped)
  File ".../toro/build/lib/test/test_rwlock.py", line 38, in test_acquire_contended
    self.assertTrue(lock.acquire_read().done())
AssertionError: False is not true

======================================================================
FAIL: test_acquire_release (test.test_rwlock.RWLockReadTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/build/lib/test/test_rwlock.py", line 24, in test_acquire_release
    self.assertTrue(lock.acquire_read().done())
AssertionError: False is not true

======================================================================
FAIL: test_acquire_callback (test.test_rwlock.RWLockReadTests2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 307, in wrapper
    result = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 277, in wrapped
    coro = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 533, in pre_coroutine
    result = f(self, *args, **kwargs)
  File ".../toro/build/lib/test/test_rwlock.py", line 161, in test_acquire_callback
    self.assertEqual(['acq1', 'acq2', 'release'], history)
AssertionError: Lists differ: ['acq1', 'acq2', 'release'] != ['release']

First differing element 0:
'acq1'
'release'

First list contains 2 additional elements.
First extra element 1:
'acq2'

- ['acq1', 'acq2', 'release']
+ ['release']

======================================================================
FAIL: test_acquire_timeout (test.test_rwlock.RWLockReadTests2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 326, in wrapper
    yielded = next(result)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 230, in __next__
    return next(self.__wrapped)
  File ".../toro/build/lib/test/test_rwlock.py", line 142, in test_acquire_timeout
    self.assertTrue(lock.acquire_read().done())
AssertionError: False is not true

======================================================================
FAIL: test_acquire_callback (test.test_semaphore.SemaphoreTests2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 125, in __call__
    result = self.orig_method(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 550, in post_coroutine
    timeout=timeout)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/ioloop.py", line 576, in run_sync
    return future_cell[0].result()
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/gen.py", line 307, in wrapper
    result = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib64/python3.7/types.py", line 277, in wrapped
    coro = func(*args, **kwargs)
  File ".../toro/.tox/py37/lib/python3.7/site-packages/tornado/testing.py", line 533, in pre_coroutine
    result = f(self, *args, **kwargs)
  File ".../toro/build/lib/test/test_semaphore.py", line 241, in test_acquire_callback
    ], history)
AssertionError: Lists differ: ['acquire1', 'release1', 'acquire2', 'release2', 'wait1', 'wait2', 'release3'] != ['release1', 'release2', 'release3']

First differing element 0:
'acquire1'
'release1'

First list contains 4 additional elements.
First extra element 3:
'release2'

- ['acquire1', 'release1', 'acquire2', 'release2', 'wait1', 'wait2', 'release3']
+ ['release1', 'release2', 'release3']

----------------------------------------------------------------------
Ran 118 tests in 3.703s

FAILED (failures=13)

Comment 4 Miro Hrončok 2018-07-29 19:21:53 UTC

Same behavior on Python 3.6.

Comment 5 Miro Hrončok 2018-07-29 19:49:43 UTC

toto README says:

Toro is completed and deprecated; its features have been merged into Tornado. Development of locks and queues for Tornado coroutines continues in Tornado itself.

Maybe thriftpy needs to drop the requirement?

Comment 6 Miro Hrončok 2018-07-30 00:21:30 UTC

You can kill this with fire.

Comment 7 Igor Raits 2018-07-30 05:15:59 UTC

Retired.