Bug 1607132

Summary: The validator "Node health check" fails with: 'dict object' has no attribute 'results'
Product: Red Hat OpenStack Reporter: Udi Kalifon <ukalifon>
Component: openstack-tripleo-validationsAssignee: Florian Fuchs <flfuchs>
Status: CLOSED ERRATA QA Contact: nlevinki <nlevinki>
Severity: low Docs Contact:
Priority: medium    
Version: 13.0 (Queens)CC: flfuchs, jjoyce, jschluet, jtomasek, lmarsh, slinaber, tvignaud
Target Milestone: z3Keywords: Rebase, Triaged, ZStream
Target Release: 13.0 (Queens)Flags: lmarsh: needinfo-
lmarsh: needinfo-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-validations-8.4.4-1.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-13 22:27:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Udi Kalifon 2018-07-22 10:44:57 UTC
Description of problem:
I upgraded the undercloud from OSP10 to OSP13 and ran this pre-upgrade validator before starting the overcloud deployment. I got this output:

Task 'Ping all overcloud nodes' failed:
Host: localhost
Message: 'dict object' has no attribute 'overcloud'

Task 'Extract failed pings' failed:
Host: localhost
Message: The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'results'

The error appears to have been in '/usr/share/openstack-tripleo-validations/validations/node-health.yaml': line 18, column 5, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    register: ping_results
  - name: Extract failed pings
    ^ here

exception type: <class 'ansible.errors.AnsibleUndefinedVariable'>
exception: 'dict object' has no attribute 'results'

Failure! The validation failed for all hosts:
* localhost


Version-Release number of selected component (if applicable):
openstack-tripleo-validations-8.4.1-5.el7ost.noarch


How reproducible:
unknown


Additional info:
1) The nodes are in ERROR state, we don't know why. We expected the validator to alert on that but it seems that it crashes. Need to check if this validator crashes also when the nodes are not in ERROR state.
2) The overcloud nodes are pingable.

Comment 9 Udi Kalifon 2018-11-13 09:29:38 UTC
Verified: openstack-tripleo-validations-9.3.1-0.20181008110747.4064fb7.el7ost.noarch

Comment 11 errata-xmlrpc 2018-11-13 22:27:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3587