Bug 1607965
| Summary: | [Infra] Transaction leak in org.opendaylight.netvirt.vpnmanager.VpnOpStatusListener | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Sai Sindhur Malleni <smalleni> |
| Component: | opendaylight | Assignee: | Stephen Kitt <skitt> |
| Status: | CLOSED ERRATA | QA Contact: | Sai Sindhur Malleni <smalleni> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 13.0 (Queens) | CC: | aadam, joflynn, jschluet, mkolesni, nyechiel, skitt, vorburger |
| Target Milestone: | z2 | Keywords: | Triaged, ZStream |
| Target Release: | 13.0 (Queens) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | Infra | ||
| Fixed In Version: | opendaylight-8.3.0-3.el7ost | Doc Type: | Bug Fix |
| Doc Text: |
Previously, the transaction did not close in netvirt.vpnmanager.VpnOpStatusListener. This resulted in memory leaks at scale and/or in longevity. This issue has been resolved and now OpenDaylight requires less memory to run.
|
Story Points: | --- |
| Clone Of: | Environment: |
N/A
|
|
| Last Closed: | 2018-08-29 16:20:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1577975 | ||
Stephen, is this one a full duplicate of Bug 1602188 and already fixed (sure?) upstream and thus coming with Oxygen SR3 (so just close as dupe?), or a separate issue that needs to be looked into? (In reply to Michael Vorburger from comment #1) > Stephen, is this one a full duplicate of Bug 1602188 and already fixed > (sure?) upstream and thus coming with Oxygen SR3 (so just close as dupe?), > or a separate issue that needs to be looked into? Not a dupe, not fixed in Oxygen, but fixed in master (https://git.opendaylight.org/gerrit/71799). I'v verified this on opendaylight-8.3.0-3.el7ost.noarch. Did not find any open transactions This bug is marked for inclusion in the errata but does not currently contain draft documentation text. To ensure the timely release of this advisory please provide draft documentation text for this bug as soon as possible. If you do not think this bug requires errata documentation, set the requires_doc_text flag to "-". To add draft documentation text: * Select the documentation type from the "Doc Type" drop down field. * A template will be provided in the "Doc Text" field based on the "Doc Type" value selected. Enter draft text in the "Doc Text" field. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:2598 |
Description of problem: Running performance and scale tests that create 100s of neutron resources like networks, subnets, ports and routers and waiting for the environment to quiesce, we observe some new transaction leaks based on Michael Vorburger's mdsal-trace tool. 55x transactions opened here, which are not closed: (...) org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataBrokerAdapter.newWriteOnlyTransaction(BindingDOMDataBrokerAdapter.java:69) (...) org.opendaylight.netvirt.vpnmanager.VpnOpStatusListener.lambda$update$3(VpnOpStatusListener.java:109) org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:416) org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60) java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402) java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) Version-Release number of selected component (if applicable): OSP13 Puddle: 2018-07-13.1 How reproducible: 100% Steps to Reproduce: 1. Run Browbeat+Rally neutron test suite 2. Get open transactions 3. Actual results: We see several open transactions after the tests finished running. Expected results: No open transactions Additional info: