Bug 1608470

Summary: When using the multiple-nics templates the deployment fails because there is no default VLAN ids in the processed nic-configs templates
Product: Red Hat OpenStack Reporter: Pedro Navarro <pnavarro>
Component: openstack-tripleo-heat-templatesAssignee: Dan Sneddon <dsneddon>
Status: CLOSED ERRATA QA Contact: mlammon
Severity: low Docs Contact:
Priority: low    
Version: 13.0 (Queens)CC: antony, bfournie, bjacot, dsneddon, ealcaniz, lmarsh, mburns, racedoro, sasha, srevivo
Target Milestone: z3Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-8.0.7-2.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-13 22:27:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pedro Navarro 2018-07-25 15:19:46 UTC 
Description of problem:

When using the multiple-nics templates the deployment fails because there is no default VLAN ids in the processed nic-configs templates


Version-Release number of selected component (if applicable): 13


How reproducible:


Steps to Reproduce:
1. Create a copy of /usr/share/openstack-tripleo-heat-templates/network/config/multiple-nics/ in your templates directory
2. Process the template using /usr/share/openstack-tripleo-heat-templates/tools/process-templates.py -p templates/ -r roles_data.yaml -n network_data.yaml -o /tmp/processed
3. Use the resulting nic-config templates to deploy an overcloud

Actual results:

Deployment fails with the following error:

2018-07-25 14:55:08Z [overcloud.Compute.0]: CREATE_FAILED  resources[0]: Property error: resources.NetworkConfig.properties: Property InternalApiNetworkVlanID not assigned
2018-07-25 14:55:08Z [overcloud.Compute]: UPDATE_FAILED  Resource CREATE failed: resources[0]: Property error: resources.NetworkConfig.properties: Property InternalApiNetworkVlanID not assigned
2018-07-25 14:55:09Z [overcloud.Compute]: CREATE_FAILED  resources.Compute: Resource CREATE failed: resources[0]: Property error: resources.NetworkConfig.properties: Property InternalApiNetworkVlanID not assigne
d
2018-07-25 14:55:09Z [overcloud]: CREATE_FAILED  Resource CREATE failed: resources.Compute: Resource CREATE failed: resources[0]: Property error: resources.NetworkConfig.properties: Property InternalApiNetworkVl
anID not assigned


Expected results:

OpenStack deployed

Additional info:

We think that the issue is in the jinja template:

# /usr/share/openstack-tripleo-heat-templates/network/config/multiple-nics/compute-dvr.j2.yaml

[...]
  {%- for network in networks %}
  {{network.name}}NetworkVlanID:
    default: {{network.vlan}}
    description: Vlan ID for the {{network.name_lower}} network traffic.
    type: number
  {%- endfor %}
[...]

This condition could be used to check if network.vlan is defined.
Comment 4 Dan Sneddon 2018-07-27 23:11:31 UTC 
Created https://review.openstack.org/586721 to fix using multiple-nics templates without VLANs defined.
Comment 5 Ramon Acedo 2018-07-30 11:16:21 UTC 
Thanks Dan. Changing component and flags in accordance to the patch. It should be set to POST once it's merged.
Comment 6 Bob Fournier 2018-09-26 15:04:27 UTC 
*** Bug 1632818 has been marked as a duplicate of this bug. ***
Comment 12 bjacot 2018-10-31 13:51:02 UTC 
Was able to run this OC deployment with the suggested changes in OSP14.

[stack@undercloud-0 ~]$ cat core_puddle_version 
2018-10-24.1
[stack@undercloud-0 ~]$ rpm -qa | grep openstack-tripleo-heat-template
openstack-tripleo-heat-templates-8.0.7-4.el7ost.noarch
Comment 14 errata-xmlrpc 2018-11-13 22:27:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3587