Bug 1608566
| Summary: | line coverage tests: glusterd crash in ./tests/basic/sdfs-sanity.t | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Shyamsundar <srangana> |
| Component: | glusterd | Assignee: | bugs <bugs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | bugs |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-5.0 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1608564 | Environment: | |
| Last Closed: | 2018-10-23 15:15:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1608564 | ||
|
Description
Shyamsundar
2018-07-25 20:13:08 UTC
REVIEW: https://review.gluster.org/20565 (sdfs: Fix missing NULL option list tremination) posted (#1) for review on master by Shyamsundar Ranganathan On further debugging: (gdb) p vol_list $12 = (volume_opt_list_t *) 0x7f2404203570 (gdb) p vol_list->given_opt $13 = (volume_option_t *) 0x7f240e02a680 <options> So we are processing given_opt and which is dynamically loaded in the function _gd_get_option_type from the xlator source. Frame 3 suggests this is sdfs (as the test is for the same). #3 0x00007f241353e76b in _gd_get_option_type (key=0x7f2408023df0 "features.sdfs") at glusterd-volgen.c:7209 Inspecting volume_options for sdfs, we can see that it is not NULL terminated, and hence can cause list options to incorrectly parsed. The patch posted in comment #1 addresses this issue. COMMIT: https://review.gluster.org/20565 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- sdfs: Fix missing NULL option list tremination Option list for volume_options in sdfs was not NULL terminated. This resulted in a crash when running in lcov based builds. This is rectified by this patch. fixes: bz#1608566 Change-Id: I5d8730f1ae963ed6adf21d970e4921c5d5d92f62 Signed-off-by: ShyamsundarR <srangana> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report. glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html [2] https://www.gluster.org/pipermail/gluster-users/ |