Bug 1608665

Summary: Default $HOME sync is too dangerous
Product: [Fedora] Fedora Reporter: Jan Kratochvil <jan.kratochvil>
Component: grive2Assignee: Zamir SUN <sztsian>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 29CC: jan.kratochvil, lupinix.fedora, moneta.mace, sztsian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-27 18:15:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Kratochvil 2018-07-26 06:23:59 UTC
Description of problem:
When I ran grive by default it tried to upload my $HOME to Google. That is insane, parameter -p should be required, not optional.
Although that is an upstream problem but still.

Version-Release number of selected component (if applicable):
grive2-0.5.0-13.20171122git84c57c1.fc28.x86_64

How reproducible:
Always.

Steps to Reproduce:
grive

Actual results:
It uploads $HOME to Google.

Expected results:
Error message one must specify -p.

Additional info:

Comment 1 Zamir SUN 2018-07-26 14:18:35 UTC
Hi Jan,

Thanks for the report. 
Are you sure for this case? In my test grive will refuse to run if no config file exists in current directory and no --path offered.

> $ grive
> Please run grive with the "-a" option if this is the first time you're accessing your Google Drive!

Can you check if you already have a grive config file under your home directory?

Comment 2 Jan Kratochvil 2018-07-26 15:17:05 UTC
[someuser@host2 ~]$ grive 
Please run grive with the "-a" option if this is the first time you're accessing your Google Drive!
[someuser@host2 ~]$ grive -a
-----------------------
Please go to this URL and get an authentication code:

https://accounts.google.com/o/oauth2/auth?scope=https%3A%2F....apps.googleusercontent.com

-----------------------
Please input the authentication code here: 
4...M
Reading local directories
Reading remote server file list
Synchronizing files
sync "./SECRETFILE-from-local-HOME" doesn't exist in server, uploading
sync "./file-from-my-googledrive" created in remote. creating local
...

It really did upload my SECRETFILE-from-local-HOME to my googledrive.

It did not ask anything before doing such insecure operation. The file has been already sent before I managed to read the line.

Normally I run some tool first to be told which options need to be specified to do what I want. The -a option in man page just says it is about authentication so I expect it will complain later it has no operation to do and I should specify some operation.

We may argue I should RTFM but still I disagree in this case.

Comment 3 Zamir SUN 2018-07-26 15:28:55 UTC
Ok, thanks. This is clear for me now.
As this is the upstream behavior, I'm move down the priority.

Comment 4 Jan Kurik 2018-08-14 10:53:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 5 Ben Cotton 2019-10-31 20:46:26 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Jan Kratochvil 2019-11-02 07:48:38 UTC
The project does not seem to be maintained upstream so I did not re-verify the bug.

Comment 7 Ben Cotton 2019-11-27 18:15:36 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.