Bug 1608758

Summary: [RFE] Update WeightedUpdateStatus to handle task cancellation and cleanup
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: AutomateAssignee: Fabien Dupont <fdupont>
Status: CLOSED WONTFIX QA Contact: Kedar Kulkarni <kkulkarn>
Severity: low Docs Contact:
Priority: high    
Version: 5.9.0CC: bascar, bthurber, cpelland, fdupont, jprause, mkanoor, obarenbo, smallamp, tfitzger
Target Milestone: GAKeywords: FutureFeature, ZStream
Target Release: 5.9.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.4.3 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1599997 Environment:
Last Closed: 2018-08-16 11:49:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1599997, 1610533    
Bug Blocks:    
Attachments:
Description Flags
ScreenVideoRecording none

Comment 2 CFME Bot 2018-08-01 00:42:07 UTC
New commits detected on ManageIQ/manageiq-content/gaprindashvili:

https://github.com/ManageIQ/manageiq-content/commit/aca058f46b5027f31fc8c6685c68555424015911
commit aca058f46b5027f31fc8c6685c68555424015911
Author:     Greg McCullough <gmccullo>
AuthorDate: Fri Jul 20 07:50:43 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Fri Jul 20 07:50:43 2018 -0400

    Merge pull request #357 from fdupont-redhat/v2v_task_cancellation_support

    Update WeightedUpdateStatus to handle task cancellation and cleanup
    (cherry picked from commit 68c1a431898448b0069654aba3816c2a94b06066)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608758

 content/automate/ManageIQ/System/CommonMethods/MiqAe.class/__methods__/weightedupdatestatus.rb | 19 +
 1 file changed, 19 insertions(+)


https://github.com/ManageIQ/manageiq-content/commit/3a98ce68ea95d6d5e4a6468c9fa1fbd04babbcf1
commit 3a98ce68ea95d6d5e4a6468c9fa1fbd04babbcf1
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Jul 30 16:50:31 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Mon Jul 30 16:50:31 2018 -0400

    Merge pull request #377 from fdupont-redhat/v2v_fix_weightedupdate_status_for_cancellation

    Fix weightedupdatestatus for cancellation
    (cherry picked from commit 100d045042d67455fe5e89893863b3c1f199beec)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608758

 content/automate/ManageIQ/System/CommonMethods/MiqAe.class/__methods__/weightedupdatestatus.rb | 6 +-
 1 file changed, 3 insertions(+), 3 deletions(-)


https://github.com/ManageIQ/manageiq-content/commit/a1db90493bec152af05c2ffbfed122dd46d3d385
commit a1db90493bec152af05c2ffbfed122dd46d3d385
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Jul 30 18:45:34 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Mon Jul 30 18:45:34 2018 -0400

    Merge pull request #378 from fdupont-redhat/v2v_cleanup_add_default_state_machine

    Add default cleanup state machine for VM transformation
    (cherry picked from commit fe3fe985101d38eee66c050562d3a7de8666e6ea)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608758

 content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformationcleanup.rb | 33 +
 content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformationcleanup.yaml | 13 +
 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/poweron.rb | 12 +-
 content/automate/ManageIQ/Transformation/Infrastructure/VM/rhevm.class/__methods__/checkpoweredon.rb | 1 +
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/__class__.yaml | 60 +-
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transformation.yaml | 2 +
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transformationcleanup.yaml | 43 +
 content/automate/ManageIQ/Transformation/TransformationHosts/Common.class/__methods__/killvirtv2v.rb | 39 +
 content/automate/ManageIQ/Transformation/TransformationHosts/Common.class/__methods__/killvirtv2v.yaml | 16 +
 9 files changed, 195 insertions(+), 24 deletions(-)

Comment 3 CFME Bot 2018-08-01 06:52:28 UTC
New commit detected on ManageIQ/manageiq-content/gaprindashvili:

https://github.com/ManageIQ/manageiq-content/commit/3d43a639999bb0194e34c8a80a7d6f360dfaa32e
commit 3d43a639999bb0194e34c8a80a7d6f360dfaa32e
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Jul 31 20:48:51 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Tue Jul 31 20:48:51 2018 -0400

    Merge pull request #382 from fdupont-redhat/v2v_fix_cleanup_state_machine_poweron

    Fix default cleanup state machine
    (cherry picked from commit 3e6a3f656cac57ad1b9ec2c1a6d1e8cdde44e6f4)

    https://bugzilla.redhat.com/show_bug.cgi?id=1608758

 content/automate/ManageIQ/System/CommonMethods/MiqAe.class/__methods__/weightedupdatestatus.rb | 1 +
 content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformationcleanup.rb | 33 -
 content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformationcleanup.yaml | 13 -
 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/checkpoweredon.rb | 41 +
 content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/__methods__/checkpoweredon.yaml | 13 +
 content/automate/ManageIQ/Transformation/Infrastructure/VM/rhevm.class/__methods__/checkpoweredon.rb | 36 -
 content/automate/ManageIQ/Transformation/Infrastructure/VM/rhevm.class/__methods__/checkpoweredon.yaml | 13 -
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/posttransform.yaml | 2 +-
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transformationcleanup.yaml | 14 +-
 9 files changed, 59 insertions(+), 107 deletions(-)

Comment 4 Kedar Kulkarni 2018-08-07 17:20:38 UTC
Moving back to Assigned as in 5.9.4.2 I can see that the RHV environment is either not cleaned correctly after cancellation or sometime virt-v2v actually migrates the VM although the VM migration was cancelled in the CFME UI.

Comment 6 CFME Bot 2018-08-08 09:53:08 UTC
New commit detected on ManageIQ/manageiq-content/gaprindashvili:

https://github.com/ManageIQ/manageiq-content/commit/1452ad84fa68470f55b2dabd0ef37405bc936188
commit 1452ad84fa68470f55b2dabd0ef37405bc936188
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Tue Aug  7 12:08:48 2018 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Tue Aug  7 12:08:48 2018 -0400

    Merge pull request #392 from fdupont-redhat/v2v_fix_cleanup_sm_path_build

    Fix cleanup state machine path build
    (cherry picked from commit c4023ec37733f5c74a8748d9beb3885aaa523a34)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608758

 content/automate/ManageIQ/System/CommonMethods/MiqAe.class/__methods__/weightedupdatestatus.rb | 1 +
 1 file changed, 1 insertion(+)

Comment 7 Kedar Kulkarni 2018-08-09 17:07:09 UTC
Pushing back to Assigned. As in 5.9.4.3 I am not able to cancel the migration successfully. CloudForms UI shows notification as "Migration Cancelled Successfully" , although, the timer and progress bar does not stop and migration is continued. On RHV I can also see disk size increasing and being transferred actively.

Comment 8 Kedar Kulkarni 2018-08-09 17:08:28 UTC
Created attachment 1474779 [details]
ScreenVideoRecording