Bug 1608973
| Summary: | Possible Patented items in gnuradio | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Olsthoorn <dave> | ||||
| Component: | gnuradio | Assignee: | Jaroslav Škarvada <jskarvad> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | jskarvad, lucilanga, mmahut, tcallawa | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | gnuradio-3.7.13.4-3.fc29 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-08-10 20:35:45 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 182235 | ||||||
| Attachments: |
|
||||||
|
Description
Dave Olsthoorn
2018-07-26 15:31:25 UTC
List of patents applying to DVB-T: http://www.sisvel.com/DVB-T/Patents.pdf List of patents applying to DVB-T2: http://www.sisvel.com/DVB-T2/Patents.pdf Github link to dvb-t sources: https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvbt Github link to dvb-t2 sources: https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvbt2 Other possibly patented decoders/encoders: dvb - https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvb note: used in other dvb decoders/encoders? atsc - https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/atsc https://github.com/gnuradio/gnuradio/tree/master/gr-atsc note: https://www.atsc.org/policies/patent-statements/ Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora package. Everything seems to have expired for DVB-T, so it could stay, but I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2 is the right decision. It seems like removing gr-atsc and gr-drv and then making rpmfusion packages for them would provide a better user experience. Jaroslav, I'll let you decide exactly how you want to do this, but the source tarball needs to be "clean", which means that the gr-atsc/ directory and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely. Note: I did a local test build removing gr-atsc/ and the gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if it actually works or not. Created attachment 1471262 [details]
cleaning script
An shell script to clean the tarball of patented content
Jaroslav? If you don't take care of this soon, I will do it for you. (In reply to Tom "spot" Callaway from comment #5) > Jaroslav? If you don't take care of this soon, I will do it for you. Sorry for delay, I will try to resolve it today. (In reply to Tom "spot" Callaway from comment #3) > Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora > package. Everything seems to have expired for DVB-T, so it could stay, but > I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2 > is the right decision. It seems like removing gr-atsc and gr-drv and then > making rpmfusion packages for them would provide a better user experience. > > Jaroslav, I'll let you decide exactly how you want to do this, but the > source tarball needs to be "clean", which means that the gr-atsc/ directory > and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely. > > Note: I did a local test build removing gr-atsc/ and the > gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if > it actually works or not. Is it needed to repack the tarball, or is it enough to drop the patented content in the %prep phase? You need to repack the tarball. Thanks for info, building the test build now. (In reply to Dave Olsthoorn from comment #4) > Created attachment 1471262 [details] > cleaning script > > An shell script to clean the tarball of patented content Thanks for the script :) I opened upstream bug: https://github.com/gnuradio/gnuradio/issues/1948 It's in the dist-git, but not build. I cannot build it on s390x due to bug 1614512. |