Bug 1609482
Summary: | Update to 6.0-4 breaks Proxmox SPICE console (timeout) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Afox <remasch> | ||||||
Component: | virt-viewer | Assignee: | Daniel Berrangé <berrange> | ||||||
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | high | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 28 | CC: | berrange, cfergeau, dani-rh, d.csapak, fidencio, marcandre.lureau, remasch, victortoso | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2018-08-16 13:20:15 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Afox
2018-07-28 10:52:03 UTC
Not too familiar with Proxmox but I take it uses NPAPI browser plugins? If that's the case, spice-gtk3 0.35 has dropped suppot to it [0]. No replacement is in place for remote-viewer so nothing to be done if that's the case. If NPAPI browser is not used, could you provide debug info to check what's going on? :) remote-viewer --spice-debug ... [0] https://gitlab.freedesktop.org/spice/spice-gtk/commit/8da3378f7d2b780acf59d01d019d9ba648deaf16 hi, thanks for the answer. I could debug the issue and it says curl: (22) The requested URL returned error: 401 Permission denied - invalid csrf token the same issue also seems to exist in openSUSE. You can find the bugreport (with more debuginfo) here: https://bugzilla.opensuse.org/show_bug.cgi?id=1102932 Created attachment 1471441 [details]
remote-viewer running with --spice-debug
Same problem for me. Proxmox is not using NPAPI, the interface just create an ini file for remote-viewer. Will post such a sample file
Created attachment 1471442 [details]
Sample ini file
Here's a sample ini file generated by Proxmox to open the spice console using remote-viewer
Downgrading to spice-glib 0.34-4.fc28 spice-gtk3 0.34-4.fc28 virt-viewer 6.0-3.fc28 And everything is working again The problematic part would be: (remote-viewer:22717): GSpice-DEBUG: 10:02:15.734: spice-session.c:2228 main-1:0: open host: Socket I/O timed out Not clear at all what could have triggered this change of behaviour between 0.34 and 0.35 though :-/ The proxy code moved from using our own copy of wocky-http to using glib code for that, maybe this is the issue (?). We also disabled TLS 1.0 support, but hopefully proxmox supports more than that... Would there be some proxmox instance I could try to reproduce this on? i played a little with the spice-gtk package on fedora and the disabled tls 1.0 is not the problem i tried to compile it with a patch that reverts the wocky removal but apparently my fedora/rpmbuild foo is not big enough as it always fails with ./.libs/libspice-client-glib-2.0.so: undefined reference to `_wocky_https_proxy_get_type' ./.libs/libspice-client-glib-2.0.so: undefined reference to `_wocky_http_proxy_get_type' and i have no idea where to look (i simply added the revert as patch to the spice-gtk.spec file from the source rpm and tried rpmbuild -bb <path>/spice-gtk.spec) i additionally have a wireshark dump here and it looks to me that the difference is indeed the proxy handling where on the old version remote-viewer sends data after the CONNECT http proxy header, the new version does not i found the problem (in our code) our spice proxy did not send the necessary empty line in the http response after "HTTP/1.0 200 OK" i sent a fix to our list, this is not a bug from fedora/glib/spice Thanks Dominik, could you please post the patch/discussion just for future reference if needed? Closing as NOTABUG as NOT-OUR-BUG does not exist here. no problem, here a link to our archive: https://pve.proxmox.com/pipermail/pve-devel/2018-August/033418.html |