Bug 1610212

Summary: After updating to RHV 4.1 while trying to edit the disk, getting error "Cannot edit Virtual Disk. Cannot edit Virtual Disk. Disk extension combined with disk compat version update isn't supported. Please perform the updates separately."
Product: Red Hat Enterprise Virtualization Manager Reporter: vaibhav <vpagar>
Component: ovirt-engineAssignee: Fedor Gavrilov <fgavrilo>
Status: CLOSED ERRATA QA Contact: Petr Kubica <pkubica>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.1.11CC: aefrat, ebenahar, eshenitz, fgavrilo, gveitmic, lsvaty, michal.skrivanek, mkalinin, mtessun, tnisan
Target Milestone: ovirt-4.4.1Keywords: Reopened
Target Release: ---Flags: lsvaty: testing_plan_complete-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.0 rhv-4.4.0-30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-04 13:16:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description vaibhav 2018-07-31 08:41:02 UTC
Description of problem:

After updating to RHV 4.1 from 4.1 while trying to edit the VMs disk we are getting below error:-

Error :-Cannot edit Virtual Disk. Cannot edit Virtual Disk. Disk extension combined with disk compat version update isn't supported. Please perform the updates separately.

Version-Release number of selected component (if applicable):

RHV-4.1.11.2-0.1.el7

How reproducible:
100%

Steps to Reproduce:

1. Install RHEV 4.0
2. Create a VM with RHEV 4.0
3. Create couple of snapshots
4. Update to RHEV 4.1
5. Create couple of new snapshots
6. Try to increase disk size 

Actual results:

Disk extend will fail with error in UI "Cannot edit Virtual Disk. Cannot edit Virtual Disk. Disk extension combined with disk compat version update isn't supported. Please perform the updates separately." 

Expected results:

Disk should get extended without any error message. 

Additional info:

I have reproduced this in my local environment and it's reproducible.

Comment 1 Michal Skrivanek 2018-08-01 04:36:30 UTC
disk extension ounds more as a storage related issue. Reassigning

Comment 2 Tal Nisan 2018-08-02 08:31:06 UTC
Seems like it is trying to amend the disk format as well, Maor this is your field, can you have a look please?

Comment 3 Maor 2018-08-13 04:28:56 UTC
Since there was a version upgrade (as mentioned in the bug) the engine storage type changed from 4.0 to 4.1 which caused the qcow volumes' version to be updated from version 0.10 to 1.1.
That is why each update of a disk with qcow volumes will cause an amend operation, that is the desired behavior.

BTW we didn't want to have all the disks being updated once the upgrade took place, to aboid any unneccessery bottlenecks and faiure handling, that is why we chose the "lazy" approach.

We do not allow to extend and amend the disk in the same operation, IINM that is because both are async tasks and we currently do not support this.

as a workaround I think that you can try to update the disk once without extending it and only then extend it.

Comment 4 Maor 2018-08-13 04:32:49 UTC
This bug should address this issue:
https://bugzilla.redhat.com/show_bug.cgi?id=1446327

Closing this one as dup, please let me know if the workaround makes sense for now.

*** This bug has been marked as a duplicate of bug 1446327 ***

Comment 5 Maor 2018-08-13 04:34:36 UTC
Small correction in my last comment:

(In reply to Maor from comment #3)
> Since there was a version upgrade (as mentioned in the bug) the engine
> storage type changed from 4.0 to 4.1

I meant that Since storage version 3 was upgraded to version 4

Comment 11 Sandro Bonazzola 2019-01-28 09:41:45 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 14 Daniel Gur 2019-08-28 13:14:42 UTC
sync2jira

Comment 15 Daniel Gur 2019-08-28 13:19:45 UTC
sync2jira

Comment 16 Shirly Radco 2019-11-25 10:40:29 UTC
*** Bug 1741724 has been marked as a duplicate of this bug. ***

Comment 17 Lukas Svaty 2020-04-09 08:30:19 UTC
Can you provide reproduction steps, please?

Comment 19 Avihai 2020-06-01 10:26:43 UTC
Hi Fedor,

Can you please provide a clear verification scenario for this bug?

The original is dealing with an upgrade from 4.0->4.1 but as 4.4 does goes back only to support 4.2,4.3 this scenario can not be tested.

Comment 21 Petr Kubica 2020-06-10 10:28:47 UTC
Verified in ovirt-engine-4.4.1.2-0.10.el8ev.noarch

Tried simultaneously extending disk and updating version qcow2_v2 to qcow2_v3 with multiple situation of the VMs: (disk with snapshots, clean disk..etc)
Didn't reproduce this issue anymore

Comment 28 errata-xmlrpc 2020-08-04 13:16:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3247