Bug 1610393

Summary: Select valid VMs by default on CSV import, but not in discovery mode
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Brett Thurber <bthurber>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.9.4CC: akarve, awight, bthurber, hkataria, jprause, lavenel, mpovolny, obarenbo, simaishi, smallamp, ytale
Target Milestone: GAKeywords: ZStream
Target Release: 5.9.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.4.4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1610382
: 1615473 (view as bug list) Environment:
Last Closed: 2018-09-05 12:56:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1610382    
Bug Blocks: 1615473    
Attachments:
Description Flags
next_button_issue_5.9.4.2.mp4
none
fixed_proof.mp4 none

Comment 3 Yadnyawalk Tale 2018-08-03 16:39:39 UTC 
On valid vm imports, vms getting selected automatically but `Next` button still not get enable by default (which is I guess should be enable by default since vm selection is already done). 

Currently to enable `Next` button we have to double-check any selected vm checkbox which is somehow weird additional thing. Not sure it is intentional since it is fairly debatable issue. 

Marking issue as FAILED_QA, we should have that `Next` button enabled.
Comment 4 Yadnyawalk Tale 2018-08-03 16:40:44 UTC 
Created attachment 1473153 [details]
next_button_issue_5.9.4.2.mp4
Comment 7 Yadnyawalk Tale 2018-08-10 07:27:52 UTC 
@Vince Conzola says,

"..I agree that when a .CSV file is imported and VMs are selected by default the Next button should be enabled without any user action required.

@priley86 or @AparnaKarve can one of you look at what's controlling enable/disable for the Next button and see if it can be enabled when the CSV file is returned and a VM is selected. Thanks."

(As per comment https://github.com/ManageIQ/miq_v2v_ui_plugin/issues/558#issuecomment-411901447)

Thank you Vince!
Comment 8 Allen W 2018-08-10 15:52:22 UTC 
https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/566

PR was created and merged!
Comment 9 Satoe Imaishi 2018-08-13 16:46:07 UTC 
*** Bug 1615473 has been marked as a duplicate of this bug. ***
Comment 11 Yadnyawalk Tale 2018-08-17 13:34:18 UTC 
Created attachment 1476628 [details]
fixed_proof.mp4

Fixed! Next button is get enabled on valid vm selection and get disabled on invalid vm selections. 

Good works folks!
Verified on: 5.9.4.4.20180816162527_c00eb23 

Thank you!