Bug 1610921

Summary: ruby: FTBFS in Rawhide
Product: [Fedora] Fedora Reporter: Pavel Valena <pvalena>
Component: rubyAssignee: Vít Ondruch <vondruch>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: mo, mtasaka, pvalena, s, strzibny, tmraz, vanmeeuwen+fedora, vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ruby-2.5.1-98.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-08 16:15:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Valena 2018-08-01 15:55:21 UTC 
Description of problem:
Test suite fails. Possibly after openssl-devel got rebased.
  https://apps.fedoraproject.org/koschei/build/5085412


Version-Release number of selected component (if applicable):
2.5.1-96.fc29


How reproducible:
100%


Actual results:
```
  1) Failure:
OpenSSL::TestConfig#test_constants [/builddir/build/BUILD/ruby-2.5.1/test/openssl/test_config.rb:32]:
Exception raised:
<#<OpenSSL::ConfigError: error in line 40: missing equal sign>>.

```


Additional info:
Failure while occurs while parsing OpenSSL::Config::DEFAULT_CONFIG_FILE file.
  https://github.com/ruby/ruby/blob/85883dc393f60adc3043d28899eff3f1ce53b4a5/test/openssl/test_config.rb#L30

Exception then is thrown after some line fails to pass regex.
  https://github.com/ruby/openssl/blob/b8b8f74e95854a8db793d8189952a51e5af53dea/lib/openssl/config.rb#L91

Note:
`openssl/lib/openssl/config.rb` did not change since Feb 23, 2017 (no new fixes).
Comment 1 Vít Ondruch 2018-08-02 10:36:12 UTC 
So this newly fails with the latest build of OpenSSL and it fails on this line:

https://src.fedoraproject.org/rpms/openssl/blob/master/f/openssl-1.1.1-conf-paths.patch#_34

Is it valid syntax to start the line with "."? Is that ".include" some new directive in OpenSSL not supported by Ruby yet? The RegExp [1] should be probably adjusted in that case

[1] https://github.com/ruby/openssl/blob/b8b8f74e95854a8db793d8189952a51e5af53dea/lib/openssl/config.rb#L91
Comment 2 Tomas Mraz 2018-08-02 11:18:13 UTC 
Yes, it is a new directive introduced in 1.1.1 - it will include the specified file.
Comment 3 Vít Ondruch 2018-08-02 11:20:36 UTC 
Actually, I was wrong about the ".". The line contains:

~~~
.include /etc/crypto-policies/back-ends/opensslcnf.config
~~~

but for INI file, it should be in format "key = value". What is this ".include" directive? I have never heard about such directive in INI files. Which INI file parsers support something like this?
Comment 4 Tomas Mraz 2018-08-02 11:49:32 UTC 
There is no promise that OpenSSL config file format is some 'standard INI file'.

The format is documented in the config manual page.
Comment 5 Vít Ondruch 2018-08-02 11:56:34 UTC 
@Tomas: Thx for the explanation.

I reported this upstream. We should probably disable this test case in the meantime.
Comment 6 Jan Kurik 2018-08-14 08:39:37 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.