Bug 1610925
| Summary: | Re-Review Request: rubygem-factory_bot - Framework and DSL for defining and using model instance factories | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Valena <pvalena> |
| Component: | Package Review | Assignee: | Jaroslav Prokop <jar.prokop> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jar.prokop, package-review |
| Target Milestone: | --- | Flags: | jar.prokop:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-factory_bot-4.10.0-1.fc29 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-08-03 18:28:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pavel Valena
2018-08-01 16:08:42 UTC
Jarku, could you take a look? Note: I'm following a guide: https://fedoraproject.org/wiki/Package_Renaming_Process New scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28767271 --- rubygem-factory_bot-new.spec 2018-08-01 15:02:49.000000000 +0200 +++ rubygem-factory_bot-old.spec 2018-08-01 15:21:44.573155613 +0200 @@ -22 +21,0 @@ -BuildRequires: rubygem(mocha) >= 0.12.8 Was not needed (dependency removed upstream). I'll take this. I reviewed the package and found no offense. But for clarity I would appreciate srpm and raw spec urls which will be uploaded. rpmlint out: ~~~ rubygem-factory_bot.spec: W: invalid-url Source2: factory_bot-4.10.0-features.tar.gz rubygem-factory_bot.spec: W: invalid-url Source1: factory_bot-4.10.0-specs.tar.gz rubygem-factory_bot.noarch: W: obsolete-not-provided rubygem-factory_girl rubygem-factory_bot.noarch: W: no-documentation rubygem-factory_bot.src: W: invalid-url Source2: factory_bot-4.10.0-features.tar.gz rubygem-factory_bot.src: W: invalid-url Source1: factory_bot-4.10.0-specs.tar.gz 3 packages and 1 specfiles checked; 0 errors, 6 warnings. ~~~ (In reply to Jaroslav Prokop from comment #4) > I reviewed the package and found no offense. But for clarity I would > appreciate srpm and raw spec urls which will be uploaded. They're available in the description/comments, but I can reiterate: SRPM: https://kojipkgs.fedoraproject.org//work/tasks/7272/28767272/rubygem-factory_bot-4.10.0-1.fc29.src.rpm Spec: https://src.fedoraproject.org/fork/pvalena/rpms/rubygem-factory_girl/raw/rebase/f/rubygem-factory_bot.spec > rpmlint out: > ~~~ > rubygem-factory_bot.spec: W: invalid-url Source2: > factory_bot-4.10.0-features.tar.gz > rubygem-factory_bot.spec: W: invalid-url Source1: > factory_bot-4.10.0-specs.tar.gz > rubygem-factory_bot.noarch: W: obsolete-not-provided rubygem-factory_girl > rubygem-factory_bot.noarch: W: no-documentation > rubygem-factory_bot.src: W: invalid-url Source2: > factory_bot-4.10.0-features.tar.gz > rubygem-factory_bot.src: W: invalid-url Source1: > factory_bot-4.10.0-specs.tar.gz > 3 packages and 1 specfiles checked; 0 errors, 6 warnings. > ~~~ Regarding the sources- it's a false positive. Please check the comments in .spec file. The procedure used to create the file is there (you can also 'unpack' it from srpm to check the content itself). (In reply to Pavel Valena from comment #5) > They're available in the description/comments, but I can reiterate: > Thanks :). > Regarding the sources- it's a false positive. > Please check the comments in .spec file. The procedure used to create the > file is there (you can also 'unpack' it from srpm to check the content > itself). I am aware of that. Package is otherwise OK. Package approved! Thanks for the review! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-factory_bot |