Bug 161191

Summary: Improvements for the rpm spec file
Product: [Fedora] Fedora Reporter: Michael Paesold <mpaesold>
Component: xenAssignee: Rik van Riel <riel>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-16 19:04:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Paesold 2005-06-21 08:28:28 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; en) Opera 8.0

Description of problem:
There are some minor improvments that could be made to the spec file:

1) Configuration
Configuration files in /etc/xen/ can and will be edited by the user, e.g. the 
xend-config.sxp file or the files in the scripts directory. I for myself have 
changed /etc/xen/vif-bridge to add firewall rules for each vif.
Therefore I propose to change the %files entry to
%{_sysconfdir}/%{name}*
to
%config(noreplace) %{_sysconfdir}/%{name}*
if that works with *, otherwise list all files explicitly.

2) Build requirements:
Building the source rpm requires the curl-devel package, please add it to 
BuildRequires.


Version-Release number of selected component (if applicable):
xen-2-20050530

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.
  

Additional info:

Comment 1 Rik van Riel 2005-09-16 18:50:49 UTC
Fixed in current release.