Bug 1612037

Summary:	Entry will be present even if the gfid link creation inside .glusterfs fails
Product:	[Community] GlusterFS	Reporter:	Karthik U S <ksubrahm>
Component:	posix	Assignee:	Karthik U S <ksubrahm>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, nchilaka, pkarampu, ravishankar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-23 15:16:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Karthik U S 2018-08-03 10:22:07 UTC

Description of problem:

If GFID hard link creation fails while doing entry creation it will ignore it and continue with the fop. Since we depend on the hard link it will lead to failure of some other operations. For example if a file needing heal does not have the gfid link assigned to it, SHD fails to heal that entry. So it is better to delete the original file in those case.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2018-08-03 10:32:01 UTC

REVIEW: https://review.gluster.org/20630 (posix: Delete the entry if gfid link creation fails) posted (#1) for review on master by Karthik U S

Comment 2 Worker Ant 2018-08-20 12:14:57 UTC

COMMIT: https://review.gluster.org/20630 committed in master by "Amar Tumballi" <amarts> with a commit message- posix: Delete the entry if gfid link creation fails

Problem:
If the gfid link file inside .glusterfs is not present for a file,
the operations which are dependent on the gfid will fail,
complaining the link file does not exists inside .glusterfs.

Fix:
If the link file creation fails, fail the entry creation operation
and delete the original file.

Change-Id: Id767511de2da46b1f45aea45cb68b98d965ac96d
fixes: bz#1612037
Signed-off-by: karthik-us <ksubrahm>

Comment 3 Shyamsundar 2018-10-23 15:16:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/