Bug 1612854

Summary: osd restart is limited to 99 OSD number
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Sébastien Han <shan>
Component: Ceph-AnsibleAssignee: Sébastien Han <shan>
Status: CLOSED ERRATA QA Contact: Vasishta <vashastr>
Severity: medium Docs Contact:
Priority: low    
Version: 3.1CC: aschoen, ceph-eng-bugs, ceph-qe-bugs, gmeno, hnallurv, kdreyer, nthomas, sankarshan, shan, vashastr
Target Milestone: rc   
Target Release: 3.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: RHEL: ceph-ansible-3.1.0-0.1.rc17.el7cp Ubuntu: ceph-ansible_3.1.0~rc17-2redhat1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-26 18:23:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sébastien Han 2018-08-06 12:18:54 UTC
Fix in regular expression matching OSD ID on non-contenerized

deployment.
restart_osd_daemon.sh is used to discover and restart all OSDs on a
host. To do it the scripts loops the list of ceph-osd@ services in the
system. This commit fixes bug in the regular expression responsible for
extraction of OSDs - prior version uses `[0-9]{1,2}` expression
which is ignoring all OSDS which numbers are greater than 99 (thus
longer than 2 digits). Fix removed upper limit of digits in the number.
This problem existed in two places in the script.

Comment 3 Ken Dreyer (Red Hat) 2018-08-09 21:24:30 UTC
"Fix in regular expression matching OSD ID on non-contenerized deployment." is in ceph-ansible v3.1.0rc14.

Comment 7 Sébastien Han 2018-08-14 08:36:32 UTC
It's fine, you can just test the regex from ceph-ansible.

Comment 10 Vasishta 2018-08-21 07:12:09 UTC
* Verified that the updated regular expression in [1] could parse 0-1000 successfully.
* Have set SanityOnly based on the discussions

Moving to VERIFIED state.

Regards,
Vasishta
QE, Ceph

[1] - https://github.com/ceph/ceph-ansible/pull/2972/files#diff-dd4df7e227c487cfcb15a8af288dcc25R77

Comment 11 Ken Dreyer (Red Hat) 2018-09-18 18:01:19 UTC
*** Bug 1612853 has been marked as a duplicate of this bug. ***

Comment 13 errata-xmlrpc 2018-09-26 18:23:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2819