Bug 1613041

Summary: [v2v] API errors in Migration Plan wizard result in broken Retry button and generic error messaging
Product: Red Hat CloudForms Management Engine Reporter: Yadnyawalk Tale <ytale>
Component: V2VAssignee: Brett Thurber <bthurber>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.9.4CC: bthurber, fdupont, hkataria, jprause, lavenel, mfeifer, mpovolny, obarenbo, simaishi, smallamp
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: 5.10.0.11 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1615470 (view as bug list) Environment:
Last Closed: 2019-02-12 16:52:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1615470    
Attachments:
Description Flags
issue_5.9.4.2.png none

Description Yadnyawalk Tale 2018-08-06 20:18:38 UTC
Created attachment 1473731 [details]
issue_5.9.4.2.png

Description of problem:
400 bad requests : Cannot create migration plan anymore - name already been taken

Version-Release number of selected component (if applicable):
5.9.4.2

How reproducible:
100%

Steps to Reproduce:
You must cause an API error. this is an improvement to the handling of an unexpected API error.

It would also be reproducible by altering the API code to force an error when POSTing a new migration plan. Tricky one, since it's the handling of an unexpected error.

Actual results:
400 bad request pop up

Expected results:
Error should not appear

Additional info:

Comment 2 Sudhir Mallamprabhakara 2018-08-08 14:07:33 UTC
https://github.com/ManageIQ/miq_v2v_ui_plugin/issues/451

Comment 4 Brett Thurber 2018-08-10 16:36:24 UTC
Upstream PR:  https://github.com/ManageIQ/manageiq-v2v/pull/541

Comment 7 Yadnyawalk Tale 2018-10-03 14:24:33 UTC
The problem was that we have fixed most of the things that were leading to API errors. But we still wanted to be prepared with a good response in case there is an API error in the future, due to some API change perhaps.

You will see earlire "We're sorry, something went wrong, please try again" with a Retry button that does nothing.

The bug was - the Retry button that does nothing, and the unhelpful error message. Mike's fix patches this behavior, it replaces "we're sorry" with the actual API error message and replaces Retry with Close.

Verified on: 5.10.0.17.20180927011235_1b5cf54
Thanks!