Bug 1613689

Summary: ose-configmap-reload and ose-grafana images are not pushed to registry.dev.redhat.io repo
Product: OpenShift Container Platform Reporter: Junqi Zhao <juzhao>
Component: ReleaseAssignee: Tim Bielawa <tbielawa>
Status: CLOSED NOTABUG QA Contact: Junqi Zhao <juzhao>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.11.0CC: ahaile, aos-bugs, fbranczy, jokerman, jupierce, mmccomas, smunilla, wsun
Target Milestone: ---Keywords: TestBlocker
Target Release: 3.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-13 15:42:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Ben Parees 2018-08-08 13:27:28 UTC
These images do not appear to be in brew either (which is why they aren't showing up in registry.dev):

$ docker pull brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/ose-configmap-reload:v3.11
Error response from daemon: unknown: Not Found

So this sounds like a release issue.

Comment 2 Tim Bielawa 2018-08-08 20:09:09 UTC
Adam, please confirm: I don't see any records to these images in the groups/ data, we do not currently build these images, do we?

Comment 3 Adam Haile 2018-08-09 10:48:23 UTC
Tim, we build configmap-reloader and grafana. Despite the name differences, these are the same images in my opinion. 
The repo name of configmap-reloader is just configmap-reload and grafana is just missing the ose- prefix, which is a common problem these days it would seem.
Again, I believe this falls under the issues we've had on the RCM config side where the name that gets pushed to the red hat registry needs to be updated.

Comment 4 Junqi Zhao 2018-08-10 00:36:36 UTC
(In reply to Adam Haile from comment #3)
> Tim, we build configmap-reloader and grafana. Despite the name differences,
> these are the same images in my opinion. 
> The repo name of configmap-reloader is just configmap-reload and grafana is
> just missing the ose- prefix, which is a common problem these days it would
> seem.
> Again, I believe this falls under the issues we've had on the RCM config
> side where the name that gets pushed to the red hat registry needs to be
> updated.

ose-configmap-reload and ose-grafana image is one fixed value, and it is set here:
https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_cluster_monitoring_operator/defaults/main.yml#L34-L35

configmap-reload:v3.11 is not found from brew, grafana:v3.11 is in brew
# docker pull brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/configmap-reload:v3.11
Trying to pull repository brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/configmap-reload ... 
unknown: Not Found

Comment 5 Junqi Zhao 2018-08-10 02:42:45 UTC
I see "ose-configmap-reloader" is pushed to registry.dev.redhat.io,
registry.dev.redhat.io/openshift3/ose-configmap-reloader                                 v3.11               ea6190f57319        4 hours ago         401 MB

But there is not "ose-configmap-reload" image
# docker pull registry.dev.redhat.io/openshift3/ose-configmap-reload:v3.11
Trying to pull repository registry.dev.redhat.io/openshift3/ose-configmap-reload ... 
unknown: Not Found

Should the image name be "ose-configmap-reloader" or "ose-configmap-reload"?
Maybe we should update our playbooks
https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_cluster_monitoring_operator/defaults/main.yml#L23-L34

Comment 6 Adam Haile 2018-08-10 11:14:47 UTC
Junqi,

The image is from the configmap-reload github repo but was requested to be called configmap-reloader -> https://projects.engineering.redhat.com/browse/RCM-37002
and https://trello.com/c/zBEHmlss/647

So we set it up with the names requested. I cannot speak to what is correct, only what was requested.

fbranczy would know

Comment 7 Frederic Branczyk 2018-08-13 15:27:02 UTC
There are some naming inconsistencies which is why it was requested that way. My apologies on not using the right repositories in openshift-ansible. I will fix those.

Comment 8 Frederic Branczyk 2018-08-13 15:28:00 UTC
Sorry, to be clear @Adam from my point of view all images are being built correctly, we just didn't use the correct ones.

Comment 9 Tim Bielawa 2018-08-13 15:42:07 UTC
(In reply to Frederic Branczyk from comment #7)
> There are some naming inconsistencies which is why it was requested that
> way. My apologies on not using the right repositories in openshift-ansible.
> I will fix those.

In that case I will close this issue so it doesn't appear as a test blocker any more. Thanks for helping get this worked out.