Bug 1613726

Summary:	virtctl refers to offline VMs
Product:	Container Native Virtualization (CNV)	Reporter:	Irina Gulina <igulina>
Component:	User Experience	Assignee:	David Vossel <dvossel>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Guohua Ouyang <gouyang>
Severity:	high	Docs Contact:
Priority:	high
Version:	1.1	CC:	fdeutsch, fsimonce, gouyang, ncredi
Target Milestone:	---
Target Release:	1.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	v0.8.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-08 14:45:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Irina Gulina 2018-08-08 08:46:24 UTC

Description of problem:
virtctl client refers to Offline VMs which were renamed to VMs.

Version-Release number of selected component (if applicable):
D/S kubevirt-virtctl-0.6.3-1.9d48bd1.x86_64

and upstream: 
https://github.com/kubevirt/kubevirt/blob/master/pkg/virtctl/vm/vm.go#L43
https://github.com/kubevirt/kubevirt/blob/master/pkg/virtctl/vm/vm.go#L58

Steps to Reproduce:
virtctl --help


Also please see: https://github.com/kubevirt/kubevirt/search?q=offline&unscoped_q=offline

Comment 1 David Vossel 2018-08-14 14:38:40 UTC

There's an upstream patch associated with this issue posted.
https://github.com/kubevirt/kubevirt/pull/1450

Comment 2 Irina Gulina 2018-08-14 17:11:49 UTC

David, thanks for the PR. It looks good.

And I'm not sure but it seems the following commands in `virtctl --help` should refer to VMI instead of VM:

```
console     Connect to a console of a virtual machine.
expose      Expose a virtual machine as a new service.
vnc         Open a vnc connection to a virtual machine.
```

If so, can you add it to that PR, please? Thanks.

Comment 3 David Vossel 2018-08-14 20:42:23 UTC

Irina, I updated the PR to more accurately reflect the help text as well.

Comment 4 Irina Gulina 2018-08-15 08:50:33 UTC

David, there is one inconsistency nit. For `start` and `stop` you made it `VirtualMachine`, and for `console, expose and vnc`  - "VMI". I believe the full plain text as `virtual machine` and `virtual machine instance` will be the best.

Comment 5 David Vossel 2018-08-15 13:41:04 UTC

fixed

Comment 6 David Vossel 2018-08-15 13:52:03 UTC

oops, looks like my previous PR got merged, here's another one with the other updates. https://github.com/kubevirt/kubevirt/pull/1453

Comment 7 Irina Gulina 2018-08-15 14:27:19 UTC

That one looks good, thanks, David.

Comment 8 Nelly Credi 2018-08-22 14:37:24 UTC

@fabian, are we planning to backport it? if so, should i target to 1.1.2?

Comment 9 Guohua Ouyang 2018-09-25 06:30:39 UTC

$ virtctl 
Available Commands:
  console     Connect to a console of a virtual machine instance.
  expose      Expose a virtual machine instance, virtual machine, or virtual machine instance replica set as a new service.
  help        Help about any command
  start       Start a virtual machine.
  stop        Stop a VirtualMachine.
  version     Print the client and server version information
  vnc         Open a vnc connection to a virtual machine instance.

Use "virtctl <command> --help" for more information about a given command.
Use "virtctl options" for a list of global command-line options (applies to all commands).

$ virtctl  version
Client Version: version.Info{GitVersion:"v0.8.0", GitCommit:"6165ead7201d8b96946fdfcfb026e44b86d3d980", GitTreeState:"clean", BuildDate:"2018-09-16T09:21:34Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: &version.Info{GitVersion:"v1.2.0-5-2-g7d06705", GitCommit:"6165ead7201d8b96946fdfcfb026e44b86d3d980", GitTreeState:"clean", BuildDate:"2018-09-12T13:49:04Z", GoVersion:"go1.9.4", Compiler:"gc", Platform:"linux/amd64"}

Comment 10 Irina Gulina 2018-09-25 07:21:02 UTC

I'm sorry, I will return this BZ to Assigned.

it should be
"  stop        Stop a virtual machine."
instead of
"  stop        Stop a VirtualMachine."

Comment 11 Irina Gulina 2018-09-25 08:24:53 UTC

ok, May this one be Verified. I opened a new BZ to fix inconsistency: https://bugzilla.redhat.com/show_bug.cgi?id=1632601