Bug 1614012

Summary: description of disk panels on host dashboard doesn't note whether it's concerned with brick devices only or not
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Martin Bukatovic <mbukatov>
Component: web-admin-tendrl-monitoring-integrationAssignee: Anmol Sachan <asachan>
Status: CLOSED ERRATA QA Contact: Filip Balák <fbalak>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.4CC: apaladug, asachan, fbalak, gshanmug, nthomas, rhs-bugs, sankarshan
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.4.z Batch Update 1Flags: gshanmug: needinfo?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tendrl-monitoring-integration-1.6.3-13.el7rhgs Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-31 08:45:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot 1: disk panels on host dashboard (with one description shown)
none
disks none

Description Martin Bukatovic 2018-08-08 19:57:59 UTC 
Description of problem
======================

Description of Disk Throughput, Disk IOPS and Disk IO Latency doesn't make it
clear if only brick disks are included here.

Version-Release number of selected component
============================================

tendrl-monitoring-integration-1.6.3-7.el7rhgs.noarch

Steps to Reproduce
==================

1. Instal RHGS WA using tendrl-ansible
2. Import Trusted storage pool with at least one volume
3. Go to Host dashboard and check Disk panels (Throughput, IOPS, IO Latency)
   in Capacity and Disk Load section there

Actual results
==============

The description doesn't mention whether only brick devices or all block devices
are accounted in these Disk panels.

Expected results
================

Description of each Disk panel makes it clear whether it covers all block
devices (including system disk) or brick devices only.
Comment 1 Martin Bukatovic 2018-08-08 20:02:08 UTC 
Created attachment 1474513 [details]
screenshot 1: disk panels on host dashboard (with one description shown)
Comment 4 gowtham 2018-09-05 15:29:09 UTC 
Proposed Description: 

The Disk IOPS panel shows the host’s aggregated read and writes disk IOPS for all the block devices over a period of time.
Comment 5 Martin Bukatovic 2018-09-06 19:21:32 UTC 
(In reply to gowtham from comment #4)
> Proposed Description: 
> 
> The Disk IOPS panel shows the host’s aggregated read and writes disk IOPS
> for all the block devices over a period of time.

I understand this as this includes device on which root filesystem is hosted
and any other block devices on the machine, is my understanding correct?

If yes, would it make sense to highlight it? Say something like:

... all the block devices (including device of root filesystem) ...

or is it extraneous and misleading?
Comment 6 Martin Bukatovic 2018-09-07 13:58:34 UTC 
Raising needinfo for comment 5.

Or we may want to write:

... all the block devices of the machine ...
Comment 7 gowtham 2018-09-10 03:41:12 UTC 
(In reply to Martin Bukatovic from comment #6)
> Raising needinfo for comment 5.
> 
> Or we may want to write:
> 
> ... all the block devices of the machine ...

I agree with this, we need Julim comment also for this
Comment 8 gowtham 2018-09-10 04:29:37 UTC 
(In reply to Martin Bukatovic from comment #5)
> (In reply to gowtham from comment #4)
> > Proposed Description: 
> > 
> > The Disk IOPS panel shows the host’s aggregated read and writes disk IOPS
> > for all the block devices over a period of time.
> 
> I understand this as this includes device on which root filesystem is hosted
> and any other block devices on the machine, is my understanding correct?
> 
> If yes, would it make sense to highlight it? Say something like:
> 
> ... all the block devices (including device of root filesystem) ...
> 
> or is it extraneous and misleading?

Yes, it includes root file system device also, In grafana we are considering everything which is start with name disk-*, please check my attachment.
Comment 9 gowtham 2018-09-10 04:30:07 UTC 
Created attachment 1481983 [details]
disks
Comment 10 gowtham 2018-09-10 06:27:38 UTC 
New description: 

The Disk IOPS panel shows the host’s aggregated read and writes disk IOPS for all the block devices of the machine over a period of time.
Comment 11 Nishanth Thomas 2018-09-10 16:26:04 UTC 
Acking the bug based on https://bugzilla.redhat.com/show_bug.cgi?id=1614012#c10
Comment 15 Filip Balák 2018-09-27 08:49:58 UTC 
Descriptions of panels are in accordance with comment 13. --> VERIFIED

Tested with:
tendrl-ansible-1.6.3-7.el7rhgs.noarch
tendrl-api-1.6.3-7.el7rhgs.noarch
tendrl-api-httpd-1.6.3-7.el7rhgs.noarch
tendrl-commons-1.6.3-12.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-13.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-13.el7rhgs.noarch
tendrl-node-agent-1.6.3-10.el7rhgs.noarch
tendrl-notifier-1.6.3-4.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-11.el7rhgs.noarch
Comment 17 errata-xmlrpc 2018-10-31 08:45:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3427