Bug 1614864
| Summary: | cancel_requested flag stored in options gets overridden | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Fabien Dupont <fdupont> | |
| Component: | Automate | Assignee: | Bill Wei <bilwei> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Kedar Kulkarni <kkulkarn> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.9.4 | CC: | bilwei, bthurber, fdupont, gmccullo, jprause, kkulkarn, mfeifer, mkanoor, obarenbo, simaishi, smallamp, tfitzger | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.10.0.23 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1616076 (view as bug list) | Environment: | ||
| Last Closed: | 2019-02-12 16:51:42 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1610533, 1616076 | |||
|
Description
Fabien Dupont
2018-08-10 14:51:41 UTC
The solution is to move the flag out of options into its own column. Reassign to Hui who provides the development work. For 5.9.z release we will be going with the fix from https://github.com/ManageIQ/manageiq-automation_engine/pull/211 to resolve this issue. The PRs mentioned in comment 4 and 5 will be moved to upstream fixes only. Moving the issue to Bill and will adjust PR labels. New commit detected on ManageIQ/manageiq-automation_engine/master: https://github.com/ManageIQ/manageiq-automation_engine/commit/20ae4d68aa3f38348767f417f88c1df3bebd9406 commit 20ae4d68aa3f38348767f417f88c1df3bebd9406 Author: Bill Wei <bilwei> AuthorDate: Fri Aug 10 16:53:22 2018 -0400 Commit: Bill Wei <bilwei> CommitDate: Fri Aug 10 16:53:22 2018 -0400 lock model object when #set_option As a temporary solution. It has a performance penalty. Ideally only one thread should update the options field. fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614864 lib/miq_automation_engine/service_models/mixins/miq_ae_service_miq_request_mixin.rb | 6 +- spec/service_models/miq_ae_service_miq_request_spec.rb | 16 +- 2 files changed, 10 insertions(+), 12 deletions(-) Simple Browser Refresh operation after cancel migration, wipes out the fact that we requested cancel migration. New commit detected on ManageIQ/manageiq-v2v/hammer: https://github.com/ManageIQ/manageiq-v2v/commit/b0f6f4a446e148078fa1f1f8227dd804beaf0b88 commit b0f6f4a446e148078fa1f1f8227dd804beaf0b88 Author: Michael Ro <mikerodev> AuthorDate: Thu Oct 18 08:19:05 2018 -0400 Commit: Michael Ro <mikerodev> CommitDate: Thu Oct 18 08:19:05 2018 -0400 Merge pull request #708 from AparnaKarve/fix_cancel_issues [699] Fix cancellation issues based on new backend changes (cherry picked from commit c45b98b81cbf38a5cc2d0f43b0fd2dc13ce0e4e7) https://bugzilla.redhat.com/show_bug.cgi?id=1614864 app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js | 31 +- app/javascript/react/screens/App/Plan/helpers.js | 2 +- 2 files changed, 23 insertions(+), 10 deletions(-) Last PR merged. Moving to POST. Should be good in next 5.10 build. *** Bug 1630013 has been marked as a duplicate of this bug. *** New commit detected on ManageIQ/manageiq-content/hammer: https://github.com/ManageIQ/manageiq-content/commit/dc010c59c769cd2e9bd0fa082b1be570d892333d commit dc010c59c769cd2e9bd0fa082b1be570d892333d Author: Greg McCullough <gmccullo> AuthorDate: Tue Nov 6 09:39:33 2018 -0500 Commit: Greg McCullough <gmccullo> CommitDate: Tue Nov 6 09:39:33 2018 -0500 Merge pull request #457 from fdupont-redhat/v2v_use_cancelation_status Use task cancelation_status to trigger cancelation (cherry picked from commit 2160a0e410fa196b6a0061a62aa36e2705586c8e) https://bugzilla.redhat.com/show_bug.cgi?id=1614864 content/automate/ManageIQ/System/CommonMethods/MiqAe.class/__methods__/weightedupdatestatus.rb | 2 +- content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation.rb | 2 +- spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation_spec.rb | 9 +- 3 files changed, 4 insertions(+), 9 deletions(-) On 5.10.0.23 I was able to cancel in progress migrations. |