Bug 1614906
Summary: | Search bar assuming dropdown causes issues when typing in partial names | |||
---|---|---|---|---|
Product: | Red Hat Satellite | Reporter: | sandeep mutkule <smutkule> | |
Component: | WebUI | Assignee: | Walden Raines <walden> | |
WebUI sub component: | Katello | QA Contact: | vijsingh | |
Status: | CLOSED ERRATA | Docs Contact: | ||
Severity: | medium | |||
Priority: | medium | CC: | bkearney, egolov, kgaikwad, mhulan, rlavi, rohoover, sgraessl, smutkule, walden | |
Version: | 6.3.0 | Keywords: | Triaged, UserExperience | |
Target Milestone: | 6.6.0 | |||
Target Release: | Unused | |||
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | tfm-rubygem-katello-3.12.0.16-1 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1650655 1650656 1650660 (view as bug list) | Environment: | ||
Last Closed: | 2019-10-22 19:47:24 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1650655, 1650656, 1650660 |
Description
sandeep mutkule
2018-08-10 17:00:35 UTC
This needs to be triaged to separate bugs. E.g. searching by erratas is not related to pagination and would be implemented separately. Some of these may already be tracked as existing BZs Hi Sandeep, Can you submit multiple RFEs as mentioned in comment 1? @Brad Sorry but I am not aware of such RFEs, but I will try to search and will let you know If I found any. Splitting apart this bug: Ans: - It should be possible to increase the number of entries shown on a page beyond 100 without manually editing the URL. [bk] Tracking this as https://bugzilla.redhat.com/show_bug.cgi?id=1650655 - If there is a reason that Content Hosts and All Hosts have different information, this information needs to be documented, and some location (either, or a third) should have the information from both of the current interfaces. [bk] We are tracking this as an interal requirement for feture deliver. - It should be possible to search by Errata number in the Errata interface. Surprisingly, this is not possible in the current version. [bk] I see id as the searchable field (e.g. id = RHBA-2018:1276) This should support the use case you are asking for. - It should be immediately evident whether the interface is still waiting for search results, or if it has returned limited (or no) content. [bk] Tracking this as https://bugzilla.redhat.com/show_bug.cgi?id=1650656 - When updating the search parameters while a search is in process, the current behavior triggers on the completion of the search - which wipes out the updated search parameters. Worse, this definitely happens when performing the initial "empty" search. That is, when you go to a page and start definining a search, it will wipe out the search criteria. And if you successfully run a search before the "empty" search completes, you instead get the initial results and not your customized results. (I preseume the search was still submitted and created load on the system, although you will never be able to see the output.) [bk] Tracking this as https://bugzilla.redhat.com/show_bug.cgi?id=1650660 - Searching on an IP address should match a subnet that includes that address. Currently it is a string based match, so 128.129.10.10 would not match the subnet definition 128.128.0.0/12 that properly includes that IP. [bk] I do not see us implementing this. - The search bar accepts suggestions from the drop-down list by default - this can easily cause incorrect behavior. This can be reliably recreated when searching errata for a package name. If you put in "package ~ " and a substring that matches the beginning of a package, hitting Enter will cause the first match to be used. The expected behavior is to require one of the matches to be selected with the mouse or arrow keys. After that, hitting Enter should run the current search exactly as typed. For clarity, this bug now tracks onlu; - The search bar accepts suggestions from the drop-down list by default - this can easily cause incorrect behavior. This can be reliably recreated when searching errata for a package name. If you put in "package ~ " and a substring that matches the beginning of a package, hitting Enter will cause the first match to be used. The expected behavior is to require one of the matches to be selected with the mouse or arrow keys. After that, hitting Enter should run the current search exactly as typed. With the new scope, I think this now falls under webui. Ron, is the new react implementation already working this way? Would it be possible to adapt it? AFK right now, but there have been some UX changes since this was opened, though the API requests and responses remained the same. I will test this behaviors first thing tomorrow. With the new SearchBar implementation on Foreman, this behavior mentioned above doesn't happen anymore. Instead of choosing the first result, hitting 'Enter' will search the query which is already inside the input, for example: --------------- Typing in: 'n' ==> receiving the result 'name' ==> selecting it by mouse / key Arrows + Enter or Tab ==> 'name' will appear in the input ==> getting results of 'name' with equality Operators ==> selecting one of the results, e.g. 'name = ' ==> 'name = ' will appear in the input ==> ==> getting a list of all suitable results ==> selecting 'name = some-host' ==> input will contain now 'name = some-host' ==> ==> getting results of the search query with operators => I don't need the operators search so I hit Enter / press the search button ==> ==> now the table or another view will get updated with my search query: 'name = some-host' --------------- Can we close this as resolved upstream per comment#12? Moving to ON_QA for verification. I'll have a look. It's possible that this is fixed in the react version of the dropdown but not the legacy katello angular version. Created redmine issue https://projects.theforeman.org/issues/26792 from this bug This has been merged with 9b403dd8c9844d9fbd25212ced0b3b22dd43c6d1, not sure why the script didn't pick it up. https://github.com/Katello/katello/pull/8234 ON_QA Verified @Satellite 6.6.0 snap 17.0 Steps/Observation: 1) It works as expected errata(Content => Errata => in Search bar put 'package ~' and selected with the mouse or arrow keys) """ put in "package ~ " and selected with the mouse or arrow keys. After that, hitting Enter run the current search exactly as typed. """ 2) It works as expected for "Hosts => All Hosts"(Instead of choosing the first result, hitting 'Enter' will search the query which is already inside the input) for example: """ Typing in: 'n' ==> receiving the result 'name' ==> selecting it by mouse / key Arrows + Enter or Tab ==> 'name' will appear in the input ==> getting results of 'name' with equality Operators ==> selecting one of the results, e.g. 'name = ' ==> 'name = ' will appear in the input ==> ==> getting a list of all suitable results ==> selecting 'name = some-host' ==> input will contain now 'name = some-host' ==> ==> getting results of the search query with operators => I don't need the operators search so I hit Enter / press the search button ==> ==> now the table or another view will get updated with my search query: 'name = some-host """ Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:3172 |