Bug 1614929

Summary:	Review Request: golang-github-fatih-set - Set data structure for Go
Product:	[Fedora] Fedora	Reporter:	redhatrises
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-04 18:29:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841, 1615641

Description redhatrises 2018-08-10 18:46:30 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-rawhide-x86_64/00786826-golang-github-fatih-set/golang-github-fatih-set.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-rawhide-x86_64/00786826-golang-github-fatih-set/golang-github-fatih-set.spec

Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28971307

Description: 
Set is a basic and simple, hash-based, Set data structure implementation in Go (Golang).
Fedora Account System Username: rga

Comment 1 redhatrises 2018-08-10 18:49:21 UTC

Dependency for part of my first package https://bugzilla.redhat.com/show_bug.cgi?id=1609038

Comment 2 redhatrises 2018-08-10 20:47:56 UTC

Added the SRPM link and had an unneeded BuildRequires:

Spec URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00786883-golang-github-fatih-set/golang-github-fatih-set.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00786883-golang-github-fatih-set/golang-github-fatih-set-0.2.1-1.fc28.src.rpm

Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28973857

Comment 3 Robert-André Mauchin 🐧 2018-08-12 19:58:32 UTC

 - Version:        0.2.1 should go before %gometa

 - You're missing the Release info in yous %changelog entry:

* Thu Aug 9 2018 Gabe <redhatrises> - 0.2.1-1

 - golang-github-fatih-set.src: E: description-line-too-long C Set is a basic and simple, hash-based, Set data structure implementation in Go (Golang).

Split the description to stay below 80 characters per line.


 - License ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines

Package approved. Fix the above issues before importing.

Comment 4 redhatrises 2018-08-13 16:08:34 UTC

Thanks for the reviewing!

Updated Spec URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00787539-golang-github-fatih-set/golang-github-fatih-set.spec
Updated SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00787539-golang-github-fatih-set/golang-github-fatih-set-0.2.1-1.fc28.src.rpm

Comment 5 Gwyn Ciesla 2018-08-27 16:34:02 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-fatih-set

Comment 6 redhatrises 2018-09-04 18:29:03 UTC

Package is now in rawhide. Thanks everyone!