Bug 1615143

Summary: python-cryptography FTBFS on F29 rawhide
Product: [Fedora] Fedora Reporter: Christian Heimes <cheimes>
Component: python-cryptographyAssignee: Christian Heimes <cheimes>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: cheimes, itamar, jeremy, nick, npmccallum, rbarlow, terrycwk1994
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-cryptography-2.3-2.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-26 16:43:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1615098    
Bug Blocks:    

Description Christian Heimes 2018-08-12 16:27:08 UTC
Description of problem:
python-cryptography started to FTBFS with latest OpenSSL 1.1.1-pre8. TestOpenSSL.test_openssl_assert_error_on_stack fails because there is an additional error on the error stack

Version-Release number of selected component (if applicable):
python-cryptography-2.3-1.fc29
openssl-1.1.1-0.pre8.2.fc29

How reproducible:
Always

Steps to Reproduce:
1. Run test suite
2.
3.

Actual results:
________________ TestOpenSSL.test_openssl_assert_error_on_stack ________________
self = <test_openssl.TestOpenSSL object at 0x3ffd08e7160>
    def test_openssl_assert_error_on_stack(self):
        b = Binding()
        b.lib.ERR_put_error(
            b.lib.ERR_LIB_EVP,
            b.lib.EVP_F_EVP_ENCRYPTFINAL_EX,
            b.lib.EVP_R_DATA_NOT_MULTIPLE_OF_BLOCK_LENGTH,
            b"",
            -1
        )
        with pytest.raises(InternalError) as exc_info:
            _openssl_assert(b.lib, False)
    
        error = exc_info.value.err_code[0]
>       assert error.code == 101183626
E       AssertionError: assert 337146240 == 101183626
E        +  where 337146240 = _OpenSSLErrorWithText(code=337146240, lib=20, func=391, reason=384, reason_text=b'error:14187180:SSL routines:ssl_do_config:bad value').code
tests/hazmat/bindings/test_openssl.py:98: AssertionError

Expected results:
No error

Additional info:

Comment 1 Christian Heimes 2018-08-13 07:01:47 UTC
Upstream has added workarounds for the issue. Tests are now using the auto-negotiate SSLv23_method (aka TLS_method). The method does not trigger bug RHBZ#1615098.

https://github.com/pyca/cryptography/pull/4389
https://github.com/pyca/cryptography/pull/4392

Comment 2 Christian Heimes 2018-08-13 08:03:38 UTC
FTBFS fixed in build https://koji.fedoraproject.org/koji/taskinfo?taskID=29040784

Comment 3 Jan Kurik 2018-08-14 11:15:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 4 Christian Heimes 2019-02-26 16:43:30 UTC
python-cryptography no longer fails to build from source.