Bug 1615287

Summary:	Allow to create VM template with preallocated file-based disk via the UI
Product:	[oVirt] ovirt-engine	Reporter:	Martin Necas <mnecas>
Component:	Frontend.WebAdmin	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Elad <ebenahar>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	future	CC:	bodnopoz, bugs, eshenitz, frolland, mkalinin, mnecas, mperina
Target Milestone:	ovirt-4.3.0	Flags:	rule-engine: ovirt-4.3+
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.0_alpha	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-13 07:48:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Necas 2018-08-13 08:59:04 UTC

Description of problem:

When you create VM with prealocated disk and then you create template from it and VM from that template.
You can see in admin GUI that the disk have thin provision, but in reality after checking mounted disks and their size, its working normally.
  

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create VM with preal. disk.
2. Create template from that VM.
3. Create VM from that template.

Actual results:

Template got disk with thin provision.
VM even if you use clone it have this provision.


Expected results:

See template and VM with prealocated disk from admin site.

Additional info:

Comment 2 Martin Perina 2018-08-16 13:10:01 UTC

As discussed in the offline email this is UI issue only in webadmin, because the reporting of disk being thin or preallocated is based on sparseness ability of the underlying storage instead of disk format

Comment 3 Marina Kalinin 2018-08-17 21:06:18 UTC

Interesting, I have just reported this bug:
Bug#1616445 - Template creation does not respect disk allocation selection on NFS domains

Comment 4 Eyal Shenitzky 2018-08-19 04:52:20 UTC

Is the disk is based on a file storage domain?

Comment 5 Martin Necas 2018-08-20 13:36:51 UTC

Yeah, it is NFS.

Comment 6 Eyal Shenitzky 2018-08-22 04:33:46 UTC

So this bug is composed of a duplication of two bugs:

1) Bug 1471138 - Creating VM from template no longer allows specification of Preallocated disks, only "RAW" or "QCOW2" - fixed partially

2) Bug 1403183 - Cloned VMs created from a template with "Raw" format are having "Thin Provision" Allocation Policy - still under development

Currently, the situation is that you can create a template from the VM with preallocated disks but only via the REST-API according to bug 1471138.

So I will not close this bug as a duplication so it will monitor the fix of to allow to create VM template with preallocated file-based disk via the UI also.

Comment 7 Eyal Shenitzky 2018-09-03 11:58:15 UTC

This fix will be relevant for cluster level >= 4.3 only.
This limitation is set to ensure all the hosts in the cluster supports in a copy of preallocated file-based disk using falloc.

Comment 8 Elad 2018-10-14 08:06:55 UTC

For a 4.3 DC, cluster:
Template disk keeps the same allocation policy as the VM it was created from.
VM created from a template doesn't keep the template disk allocation policy (so VM created from a template with a preallocated disk is being created with a thin disk) - this will be handled as part of bug 1403183.
Also, template creation prompt doesn't include allocation policy. The template simply inherits the VM disk one.

Used:
4.3.0-0.0.master.20181009124701.gitbd53f5b.el7

Comment 9 Sandro Bonazzola 2018-11-02 14:30:42 UTC

This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 10 Sandro Bonazzola 2018-11-02 15:06:10 UTC

Closed by mistake, moving back to qa -> verified

Comment 11 Sandro Bonazzola 2019-02-13 07:48:06 UTC

This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.