Bug 1615474

Summary:	Rebalance status shows wrong count of "Rebalanced-files" if the file has hardlinks
Product:	[Community] GlusterFS	Reporter:	Nithya Balachandran <nbalacha>
Component:	distribute	Assignee:	Nithya Balachandran <nbalacha>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, rhs-bugs, sankarshan, storage-qa-internal, tdesala
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1615338	Environment:
Last Closed:	2018-10-23 15:17:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1615338
Bug Blocks:

Description Nithya Balachandran 2018-08-13 16:45:37 UTC

+++ This bug was initially created as a clone of Bug #1615338 +++

Description of problem:
=======================
Rebalance status shows wrong count of "Rebalanced-files" if the file has hardlinks.


How reproducible:
=================
always

Steps to Reproduce:
====================
1) Create a distributed-replicate volume and start it.
2) FUSE mount it on a client.
3) Create 10k file and create one hardlink for each file. (total number of files will be 20k)
4) Now, add-brick and trigger rebalance.
5) Wait till the rebalance completes.

Actual results:
===============
Rebalance status shows wrong count of "Rebalanced-files" if the file has hardlinks.

Expected results:
=================
Rebalance should skip all the files as every file has hardlinks. So, the total number of "Rebalanced-files" in rebalance status should be '0'



Introduced by commit a96c7e74. I shall send a patch.

Comment 1 Worker Ant 2018-08-13 16:52:20 UTC

REVIEW: https://review.gluster.org/20724 (cluster/dht: Fixed rebalanced files) posted (#1) for review on master by N Balachandran

Comment 2 Worker Ant 2018-08-14 12:23:21 UTC

COMMIT: https://review.gluster.org/20724 committed in master by "Atin Mukherjee" <amukherj> with a commit message- cluster/dht: Fixed rebalanced files

An error caused skipped files to be counted as
rebalanced files.

Change-Id: I02333f099fb8b73ba953f41a2922021a1e4da7be
fixes: bz#1615474
Signed-off-by: N Balachandran <nbalacha>

Comment 3 Shyamsundar 2018-10-23 15:17:10 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/