Bug 1615634

Summary:	Ordering a service using $evm.execute('create_service_provision_request') doesn't honor the dialog options
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Automate	Assignee:	eclarizi
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kedar Kulkarni <kkulkarn>
Severity:	urgent	Docs Contact:
Priority:	high
Version:	5.9.4	CC:	bthurber, dmetzger, duhlmann, fdupont, gblomqui, kkulkarn, mkanoor, obarenbo, pmcgowan, tfitzger
Target Milestone:	GA	Keywords:	Regression, ZStream
Target Release:	5.9.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.4.4	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1613935	Environment:
Last Closed:	2018-09-05 12:57:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1613935
Bug Blocks:

Comment 1 CFME Bot 2018-08-14 21:46:04 UTC

New commit detected on ManageIQ/manageiq/gaprindashvili:

https://github.com/ManageIQ/manageiq/commit/c00eb230a88f0c653197c4870ff855de745ab60d
commit c00eb230a88f0c653197c4870ff855de745ab60d
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Aug 13 16:57:22 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Mon Aug 13 16:57:22 2018 -0400

    Merge pull request #17844 from eclarizio/BZ1613935

    Fix for $evm.execute not honoring dialog options
    (cherry picked from commit e8ff2a422a9965d700bac5331fd4c5093eb8b436)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1615634

 app/models/dialog.rb | 9 +-
 app/models/resource_action_workflow.rb | 3 +
 app/models/service_template.rb | 17 +-
 spec/models/dialog_spec.rb | 56 +
 spec/models/resource_action_workflow_spec.rb | 10 +
 spec/models/service_template_spec.rb | 25 +-
 6 files changed, 109 insertions(+), 11 deletions(-)

Comment 2 Kedar Kulkarni 2018-08-20 20:07:10 UTC

During v2v Pre-migration playbook execution I was able to see that Ansible playbook service did correctly find the IP address of VM being migrated correctly. So I think this verifies the fix.