Bug 1615703

Summary: [Disperse] Improve log messages for EC volume
Product: [Community] GlusterFS Reporter: Ashish Pandey <aspandey>
Component: disperseAssignee: Ashish Pandey <aspandey>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: aspandey, bugs, sankarshan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1625622 (view as bug list) Environment:
Last Closed: 2018-10-23 15:17:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1625622    

Description Ashish Pandey 2018-08-14 05:28:14 UTC 
Description of problem:


Some of the function should have more description or information about files on which a fop failed.


r.log:404102:[2018-07-23 22:04:13.041491] W [MSGID: 122040] [ec-common.c:990:ec_prepare_update_cbk] 0-vol01-disperse-1: Failed to get size and version [Input/output error]


[2018-07-23 22:04:13.044413] W [MSGID: 122040] [ec-common.c:990:ec_prepare_update_cbk] 0-vol01-disperse-1: Failed to get size and version [Input/output error]

[2018-07-23 22:04:13.044637] E [MSGID: 122037] [ec-common.c:1914:ec_update_size_version_done] 0-vol01-disperse-1: Failed to update version and size [Input/output error]

[2018-07-23 22:05:14.925594] W [MSGID: 122040] [ec-common.c:990:ec_prepare_update_cbk] 0-vol01-disperse-1: Failed to get size and version [Input/output error]



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Ashish Pandey 2018-08-20 03:43:46 UTC 

In this case, it should provide for which file/gfid it has failed.

Example : 

[2018-07-23 22:05:14.925594] W [MSGID: 122040] [ec-common.c:990:ec_prepare_update_cbk] 0-vol01-disperse-1: Failed to get size and version [Input/output error] gfid : XXXXXXXXXXX


or 


[2018-07-23 22:05:14.925594] W [MSGID: 122040] [ec-common.c:990:ec_prepare_update_cbk] 0-vol01-disperse-1: Failed to get size and version [Input/output error] loc: YYYYYYYYYYY
Comment 3 Worker Ant 2018-09-03 08:33:58 UTC 
REVIEW: https://review.gluster.org/21061 (cluster/ec: Improve logging for some critical error messages) posted (#1) for review on master by Ashish Pandey
Comment 4 Worker Ant 2018-09-07 07:23:55 UTC 
COMMIT: https://review.gluster.org/21061 committed in master by "Xavi Hernandez" <xhernandez> with a commit message- cluster/ec: Improve logging for some critical error messages

Change-Id: I037e52a3467467b81a1ba5416317870864060d4d
updates: bz#1615703
Signed-off-by: Ashish Pandey <aspandey>
Comment 5 Shyamsundar 2018-10-23 15:17:10 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/