Bug 161598
| Summary: | sr_open: remove random call to scsi_cd_put | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | nate.dailey |
| Component: | kernel | Assignee: | Doug Ledford <dledford> |
| Status: | CLOSED NOTABUG | QA Contact: | Brian Brock <bbrock> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.0 | CC: | coughlan, davej, jbaron |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | i686 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-02 13:59:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This was fixed some time ago and doesn't exist in the current tree, so closing as NOTABUG (I would use CURRENTRELEASE, but they want to know *what* release it was fixed in for that and I don't have that answer, I just know it's fixed now). |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2 Description of problem: This patch removes a call to scsi_cd_put from the error_out section of sr_open. I don't know why this is in there, but it seems like a bad idea (and it's not there in the latest kernel.org kernel). --- sr.c.orig 2005-06-24 14:39:38.000000000 -0400 +++ sr.c 2005-06-24 14:40:18.000000000 -0400 @@ -544,7 +544,6 @@ static int sr_open(struct cdrom_device_i return 0; error_out: - scsi_cd_put(cd); return retval; } Version-Release number of selected component (if applicable): kernel-2.6.9-5.EL How reproducible: Didn't try Steps to Reproduce: Additional info: