Bug 1616043

https://github.com/redhat-performance/tuned/commit/efcb477299dd4720f0012c3d95a8feb6d6841eac

Hi, bug found. There is missing section [script] in tuned/realtime-virtual-guest/tuned.conf file.

# cd /usr/lib/tuned/realtime-virtual-guest/tuned.conf
# diff tuned.conf.old tuned.conf.new
8a9,12
> [script]
> script=${i:PROFILE_DIR}/script.sh
>

Also there are missing executable rights to script.sh

so, it need:
# chmod +x /usr/lib/tuned/realtime-virtual-guest/script.sh

Created attachment 1481262 [details]
Fixed patch

Fixed patch which calls the script.sh from realtime-virtual-guest profile.

(In reply to Tereza Cerna from comment #5)
> Hi, bug found. There is missing section [script] in
> tuned/realtime-virtual-guest/tuned.conf file.
> 
> # cd /usr/lib/tuned/realtime-virtual-guest/tuned.conf
> # diff tuned.conf.old tuned.conf.new
> 8a9,12
> > [script]
> > script=${i:PROFILE_DIR}/script.sh
> >

Thanks, fixed in the attached patch.

(In reply to Tereza Cerna from comment #6)
> Also there are missing executable rights to script.sh
> 
> so, it need:
> # chmod +x /usr/lib/tuned/realtime-virtual-guest/script.sh

IMHO it shouldn't block the script execution, but also fixed.

(In reply to Jaroslav Škarvada from comment #9)
> (In reply to Tereza Cerna from comment #6)
> > Also there are missing executable rights to script.sh
> > 
> > so, it need:
> > # chmod +x /usr/lib/tuned/realtime-virtual-guest/script.sh
> 
> IMHO it shouldn't block the script execution, but also fixed.

Well, it seems it does :) The patch is OK but due to rpmbuild bug 1626473 we need to add workaround into the spec.

(In reply to Jaroslav Škarvada from comment #10)
> (In reply to Jaroslav Škarvada from comment #9)
> > (In reply to Tereza Cerna from comment #6)
> > > Also there are missing executable rights to script.sh
> > > 
> > > so, it need:
> > > # chmod +x /usr/lib/tuned/realtime-virtual-guest/script.sh
> > 
> > IMHO it shouldn't block the script execution, but also fixed.
> 
> Well, it seems it does :) The patch is OK but due to rpmbuild bug 1626473 we
> need to add workaround into the spec.

Addressed in tuned-2.10.0-6.el7.

Tested in:
    tuned-profiles-nfv-host-2.10.0-6.el7.noarch
    tuned-profiles-nfv-guest-2.10.0-6.el7.noarch
    rt-setup-2.0-6.el7.x86_64
PASS


::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Test profile realtime-virtual-host
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
[ LOG  ] :: Output of 'systemctl status rt-entsk | grep 'Active: inactive (dead)'':
[ LOG  ] :: --------------- OUTPUT START ---------------
[ LOG  ] :: Active: inactive (dead)
[ LOG  ] :: ---------------  OUTPUT END  ---------------
[ PASS ] :: Command 'systemctl status rt-entsk | grep 'Active: inactive (dead)'' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm profile realtime-virtual-host' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm active | grep realtime-virtual-host' (Expected 0, got 0)
[ LOG  ] :: Output of 'systemctl status rt-entsk | grep 'Active: active (running)'':
[ LOG  ] :: --------------- OUTPUT START ---------------
[ LOG  ] :: Active: active (running) since Mon 2018-09-10 16:04:11 CEST; 2s ago
[ LOG  ] :: ---------------  OUTPUT END  ---------------
[ PASS ] :: Command 'systemctl status rt-entsk | grep 'Active: active (running)'' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm profile balanced' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm active | grep balanced' (Expected 0, got 0)
[ LOG  ] :: Output of 'systemctl status rt-entsk | grep 'Active: inactive (dead)'':
[ LOG  ] :: --------------- OUTPUT START ---------------
[ LOG  ] :: Active: inactive (dead)
[ LOG  ] :: ---------------  OUTPUT END  ---------------
[ PASS ] :: Command 'systemctl status rt-entsk | grep 'Active: inactive (dead)'' (Expected 0, got 0)
:::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 10s
::   Assertions: 7 good, 0 bad
::   RESULT: PASS


::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Test profile realtime-virtual-guest
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
[ LOG  ] :: Output of 'systemctl status rt-entsk | grep 'Active: inactive (dead)'':
[ LOG  ] :: --------------- OUTPUT START ---------------
[ LOG  ] :: Active: inactive (dead)
[ LOG  ] :: ---------------  OUTPUT END  ---------------
[ PASS ] :: Command 'systemctl status rt-entsk | grep 'Active: inactive (dead)'' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm profile realtime-virtual-guest' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm active | grep realtime-virtual-guest' (Expected 0, got 0)
[ LOG  ] :: Output of 'systemctl status rt-entsk | grep 'Active: active (running)'':
[ LOG  ] :: --------------- OUTPUT START ---------------
[ LOG  ] :: Active: active (running) since Mon 2018-09-10 16:04:21 CEST; 2s ago
[ LOG  ] :: ---------------  OUTPUT END  ---------------
[ PASS ] :: Command 'systemctl status rt-entsk | grep 'Active: active (running)'' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm profile balanced' (Expected 0, got 0)
[ PASS ] :: Command 'tuned-adm active | grep balanced' (Expected 0, got 0)
[ LOG  ] :: Output of 'systemctl status rt-entsk | grep 'Active: inactive (dead)'':
[ LOG  ] :: --------------- OUTPUT START ---------------
[ LOG  ] :: Active: inactive (dead)
[ LOG  ] :: ---------------  OUTPUT END  ---------------
[ PASS ] :: Command 'systemctl status rt-entsk | grep 'Active: inactive (dead)'' (Expected 0, got 0)
:::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 10s
::   Assertions: 7 good, 0 bad
::   RESULT: PASS

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3172