Bug 1616059

Summary:	CVE-2018-14641 CVE-2018-5391 kernel: various flaws [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Vladis Dronov <vdronov>
Component:	kernel	Assignee:	Kernel Maintainer List <kernel-maint>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	28	CC:	airlied, bskeggs, ewk, hdegoede, ichavero, itamar, jarodwilson, jforbes, jglisse, john.j5live, jonathan, josef, jwboyer, kernel-maint, labbott, linville, mchehab, mjg59, sardella, steved
Target Milestone:	---	Keywords:	Reopened, Security, SecurityTracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Release Note
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-17 12:53:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1609664, 1629636

Description Vladis Dronov 2018-08-14 20:09:20 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Reproducers, if any, will remain confidential and never be made public, unless done so by the security team.

Comment 1 Vladis Dronov 2018-08-14 20:09:30 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1609664,1616059

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Justin M. Forbes 2018-08-15 20:05:41 UTC

This was fixed for Fedora with the 4.17.13 stable kernel updates.

Comment 3 Vladis Dronov 2018-09-14 12:40:48 UTC

There are 2 more upstream patches that fix upstream's fa0f527358bd which was backported to Fedora. we believe the below 2 patches should be backported also, as they have direct security impact:

commit 5d407b071dc369c26a38398326ee2be53651cfe4
Author: Taehee Yoo <ap420073>
Date:   Mon Sep 10 02:47:05 2018 +0900
ip: frags: fix crash in ip_do_fragment()

commit 70837ffe3085c9a91488b52ca13ac84424da1042
Author: Dan Carpenter <dan.carpenter>
Date:   Mon Aug 6 22:17:35 2018 +0300
ipv4: frags: precedence bug in ip_expire()

Comment 4 Justin M. Forbes 2018-09-14 18:59:29 UTC

70837ffe3085c9a91488b52ca13ac84424da1042 fixes a bug that was introduced 4 days prior, it should not be in any shipped tree anywhere.

Comment 5 Laura Abbott 2018-09-16 17:44:29 UTC

5d407b071dc3 ("ip: frags: fix crash in ip_do_fragment()") fixes tag that is only applicable to rawhide

$ git tag --contains fa0f527358bd
v4.19-rc1
v4.19-rc2
v4.19-rc3

Comment 6 Justin M. Forbes 2018-09-17 12:53:54 UTC

Closing this as neither patch is relevant to Fedora.

Comment 7 Justin M. Forbes 2018-09-18 12:54:23 UTC

*** Bug 1630279 has been marked as a duplicate of this bug. ***

Comment 8 Vladis Dronov 2018-09-25 10:35:39 UTC

these bugs are relevant to fedora, as they existed not only in 4.19-rc kernels, but in all kernels which has backported fa0f527358bd in order to fix CVE-2018-5391, i.e. in fedora-27/28 also.

now fedora-27/28 has this fix for fa0f527358bd, thank you:

https://src.fedoraproject.org/cgit/rpms/kernel.git/commit/?h=f27&id=dfce0df4f20e7da1c5c707dabd658d657ee7aac5

https://src.fedoraproject.org/cgit/rpms/kernel.git/commit/?h=f28&id=0fc194c42cc120bc3f00abfe5d57450b6a29681a