Bug 1617373

Summary: notify_api_faults is no more used in nova
Product: Red Hat OpenStack Reporter: Keigo Noha <knoha>
Component: puppet-novaAssignee: Rajesh Tailor <ratailor>
Status: CLOSED ERRATA QA Contact: OSP DFG:Compute <osp-dfg-compute>
Severity: medium Docs Contact:
Priority: medium    
Version: 13.0 (Queens)CC: jjoyce, jschluet, lyarwood, mariel, nlevinki, ratailor, slinaber, tvignaud
Target Milestone: z4Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: puppet-nova-12.4.0-11.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-01-16 17:55:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Keigo Noha 2018-08-16 03:30:37 UTC
Description of problem:
notify_api_faults is no more used in nova

Version-Release number of selected component (if applicable):
Current puppet-nova

How reproducible:
Everytime

Steps to Reproduce:
1. Deploy overcloud


Actual results:
notify_api_faults is added into nova.conf

Expected results:
notify_api_faults is not added into nova.conf.

Additional info:
Upstream commit for this issue.

commit e9aa809dd394b58c96ed8659005f1d295b8119b2
Author: Pierre Riteau <priteau>
Date:   Wed Mar 28 14:28:05 2018 +0100

    Deprecate notify_api_faults for notify_on_api_faults
    
    When Nova moved notification parameters from [DEFAULT] to
    [notifications], notify_api_faults was renamed to notify_on_api_faults.
    However, the Puppet code was not updated to follow this change.
    
    This commit sets notifications/notify_on_api_faults in nova.conf,
    introduces a new parameter notify_on_api_faults, and deprecates
    notify_api_faults.
    
    Change-Id: I128c716af1dc54bb13ac2c5c713f5815708a7a1a

But it doesn't catch up the latest changes in nova.

https://github.com/openstack/nova/commit/0d4c3cc65b78bafef69afc45cb156afe38f857c3#diff-555d7affed89d18c29ff5a23919025d2

Comment 2 Rajesh Tailor 2018-09-18 06:02:16 UTC
Hi Keigo,

I will try to backport it till stable/queens upstream and will backport to OSP13 once it lands in upstream releases.

Comment 3 Keigo Noha 2018-11-07 00:05:53 UTC
Hello Rajesh,

The upstream gerrit was merged status.
Could you proceed this bugzilla forward?

Best Regards,
Keigo Noha

Comment 17 errata-xmlrpc 2019-01-16 17:55:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0068