Bug 1618377

Summary: lldpad: Support DSCP selectors in APP TLVs
Product: [Fedora] Fedora Reporter: Petr Machata <me>
Component: lldpadAssignee: Chris Leech <cleech>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: cleech, jiri
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lldpad-1.0.1-10.git036e314.fc28 lldpad-1.0.1-12.git036e314.fc29 lldpad-1.0.1-9.git036e314.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-26 17:06:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Packaging patch none

Description Petr Machata 2018-08-16 13:59:51 UTC 
The P802.1Qcd/D2.1 standard draft introduces a new APP TLV to assign packet priority based on IP DSCP header. Support for this has been recently added to lldpad upstream[0], and has been in the upstream kernel since 4.15[1]. Some drivers already take advantage of the possibility to configure DSCP-to-priority mappings (e.g. mlx5), mlxsw will support this from 4.19.

Please consider applying the patch to Fedora package of lldpad.

[0] https://github.com/intel/openlldp/pull/9#issuecomment-404650581
[1] http://patchwork.ozlabs.org/patch/834246/

Version-Release number of selected component (if applicable):
lldpad-1.0.1-11.git036e314.fc29

How reproducible:
Always.

Steps to Reproduce:
1. service lldpad start
2. lldptool -T -i $PORT -V APP app=3,5,24
3. lldptool -t -i $PORT -V APP -c app


Actual results:
# lldptool -T -i sw1p5 -V APP    app=3,5,24
Invalid command c: selector out of range
# lldptool -t -i sw1p5 -V APP -c app
APP=(prio,sel,proto)


Expected results:
# lldptool -T -i sw1p5 -V APP    app=3,5,24                                                                                                                                                                                                        
# lldptool -t -i sw1p5 -V APP -c app
APP=(prio,sel,proto)
0:(3,5,24) local  hw (unknown)


Additional info:
Comment 1 Petr Machata 2018-08-16 14:23:41 UTC 
Created attachment 1476431 [details]
Packaging patch

This patch modifies the Fedora package to include the patch necessary for support of DSCP APP TLVs in lldpad.
Tested this on a switch, the two tests that exercise the relevant lldpad code both passed.
Comment 2 Petr Machata 2018-09-07 17:01:35 UTC 
Is there anything I can do to help push this along? I filed a couple requests in https://src.fedoraproject.org/rpms/lldpad/pull-requests so getting the patch in should be a one-click thing.
Comment 3 Fedora Update System 2018-10-23 00:47:12 UTC 
lldpad-1.0.1-10.git036e314.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-cec7093baa
Comment 4 Fedora Update System 2018-10-23 00:47:21 UTC 
lldpad-1.0.1-12.git036e314.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-06d56c8c9d
Comment 5 Fedora Update System 2018-10-23 17:10:09 UTC 
lldpad-1.0.1-12.git036e314.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-06d56c8c9d
Comment 6 Fedora Update System 2018-10-23 21:30:54 UTC 
lldpad-1.0.1-10.git036e314.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-cec7093baa
Comment 7 Fedora Update System 2018-10-26 17:06:57 UTC 
lldpad-1.0.1-10.git036e314.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2018-10-29 11:44:12 UTC 
lldpad-1.0.1-9.git036e314.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e9d1ec6dbc
Comment 9 Fedora Update System 2018-10-31 19:45:23 UTC 
lldpad-1.0.1-9.git036e314.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e9d1ec6dbc
Comment 10 Fedora Update System 2018-11-03 00:00:58 UTC 
lldpad-1.0.1-12.git036e314.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2018-11-16 03:41:41 UTC 
lldpad-1.0.1-9.git036e314.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.