Bug 1620171

Summary: Nova puts virtio RX/TX Queue Size on SRIOV ports failing VM creation
Product: Red Hat OpenStack Reporter: Federico Iezzi <fiezzi>
Component: openstack-novaAssignee: OSP DFG:Compute <osp-dfg-compute>
Status: CLOSED ERRATA QA Contact: OSP DFG:Compute <osp-dfg-compute>
Severity: medium Docs Contact:
Priority: medium    
Version: 13.0 (Queens)CC: atelang, berrange, cfontain, dasmith, dhill, eglynn, fherrman, fiezzi, jhakimra, jraju, kchamart, lyarwood, mbabushk, moshele, nova-maint, owalsh, sbauza, sgordon, srevivo, supadhya, vkhitrin, vromanso, yrachman, zgreenbe
Target Milestone: z3Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-nova-17.0.5-4.d7864fbgit.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1625178 1625179 1625180 (view as bug list) Environment:
Last Closed: 2018-11-13 22:13:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1625178, 1625179, 1625180, 1638299    
Attachments:
Description Flags
sosreport none

Description Federico Iezzi 2018-08-22 15:14:56 UTC
Description of problem:

Nova compute forces the virtio RX/TX Queue Size also on SRIOV devices.
This makes VM spawn to fail. The configurable RX/TX Queue Size code is similar all the way from OSP10 to OSP13, so it's possible the issue is present also on other releases.

Version-Release number of selected component (if applicable):
OSP13 z3

How reproducible:

(quick and dirty way)
Change nova config file 

# crudini --set /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf libvirt rx_queue_size 1024
# crudini --set /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf libvirt tx_queue_size 1024
 
# restart nova_compute container
docker restart nova_compute

# boot a VM with an SRIOV (PF or VF) interface

Actual results:
Nova add on the sriov port section rx_queue_size

    <interface type="hostdev" managed="yes">
      <mac address="fa:16:3e:9d:f0:52"/>
      <driver name="vhost" rx_queue_size="1024"/>
      <source>
        <address type="pci" domain="0x0000" bus="0x01" slot="0x14" function="0x7"/>
      </source>
      <vlan>
        <tag id="435"/>
      </vlan>

Expected results:

    <interface type='hostdev' managed='yes'>
      <mac address='fa:16:3e:83:b2:84'/>
      <driver name='vfio'/>
      <source>
        <address type='pci' domain='0x0000' bus='0x01' slot='0x14' function='0x7'/>
      </source>
      <vlan>
        <tag id='435'/>
      </vlan>
      <alias name='hostdev0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
    </interface>

Additional info:

Comment 1 Federico Iezzi 2018-08-22 15:18:39 UTC
Created attachment 1477912 [details]
sosreport

Attached sosreport with nova logs

Comment 2 Federico Iezzi 2018-08-22 15:19:53 UTC
Ops little mistake.
Version-Release number of selected component (if applicable):
OSP13 z3

I meant, OSP13 z1

Comment 3 Sahid Ferdjaoui 2018-08-23 12:49:24 UTC
It's a valid issue a patch has been sent upstream but still need some work

  https://review.openstack.org/#/c/595592/

Comment 7 Federico Iezzi 2018-08-29 08:07:24 UTC
(In reply to Sahid Ferdjaoui from comment #3)
> It's a valid issue a patch has been sent upstream but still need some work
> 
>   https://review.openstack.org/#/c/595592/

Tested upstream patch and it works as expected. The rx_queue_size queue size is not enforced anymore on SR-IOV devices.
Test done using both SR-IOV VF (aka neutron port type direct) and SR-IOV PF (aka neutron port type direct-physical)
Thanks!

Comment 8 Vadim Khitrin 2018-10-03 10:50:26 UTC
*** Bug 1635568 has been marked as a duplicate of this bug. ***

Comment 9 Shelley Dunne 2018-10-12 15:33:59 UTC
Updating Target Milestone to z3 for all Modified medium bugs

Comment 20 errata-xmlrpc 2018-11-13 22:13:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3602

Comment 21 Red Hat Bugzilla 2023-09-18 00:14:19 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days