Bug 162140

Summary:	operation on 'nbr_opened_channels' may be undefined
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	gnomemeeting	Assignee:	Alexander Larsson <alexl>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	FC5	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-08-14 12:50:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Binderman 2005-06-30 09:59:11 UTC

Description of problem:

I just tried to compile package gnomemeeting-1.2.1-1 from Redhat
Fedora Core development tree with the gcc 4.0.0 compiler and
the compiler flag -Wall.

The compiler said

sound_handling.cpp:486: warning: operation on 'nbr_opened_channels' may be undefined

The source code is

  nbr_opened_channels = PMAX (nbr_opened_channels--, 0);

I agree with the compiler. Suggest avoid post decrement on macro
parameters.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Alexander Larsson 2006-08-14 12:50:34 UTC

Seems fixed in later versions.